Issue 1337243004: Don't use openat64 in fcntl2.h under NaCl

Issue 1337243004: Don't use openat64 in fcntl2.h under NaCl (Closed)

Created:
5 years, 3 months ago by Sam Clegg

Modified:
5 years, 1 month ago

Reviewers:
Roland McGrath

CC:
native-client-reviews_googlegroups.com, Mark Seaborn

Base URL:
https://chromium.googlesource.com/native_client/nacl-glibc.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use openat64 in fcntl2.h under NaCl The NaCl build used 64-bit symbols by default and openat64 is therefore not available. fcntl2.h is only used when _FORTITY_SOURCE > 2. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4241 TEST= local verification + trybots R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=818c8d36ff030bf1fc0e7b79df0635304edd4594

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	io/bits/fcntl2.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (3 generated)

Roland McGrath

Needs BUG= and TEST= lines. LGTM with green toolchain trybot.

5 years, 3 months ago (2015-09-14 17:12:43 UTC) #3

Sam Clegg

Trybot is green: http://build.chromium.org/p/tryserver.nacl/builders/nacl-toolchain-precise64-glibc/builds/165

5 years, 1 month ago (2015-11-10 00:03:40 UTC) #6

Sam Clegg

5 years, 1 month ago (2015-11-10 00:04:40 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
818c8d36ff030bf1fc0e7b79df0635304edd4594 (presubmit successful).