Extracted hardcoded constants from cast_rtp_stream.

media/cast/cast_defines.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_CAST_DEFINES_H_
 #define MEDIA_CAST_CAST_DEFINES_H_
 
 #include <stdint.h>
 
 #include <cmath>
@@ skipping 10 matching lines @@
 namespace cast {
 
 const int64 kDontShowTimeoutMs = 33;
 const float kDefaultCongestionControlBackOff = 0.875f;
 const uint32 kVideoFrequency = 90000;
 const uint32 kStartFrameId = UINT32_C(0xffffffff);
 
 // This is an important system-wide constant.  This limits how much history the
 // implementation must retain in order to process the acknowledgements of past
 // frames.
 // This value is carefully choosen such that it fits in the 8-bits range for

[ajose, 2015/09/14 16:28:43]

s/choosen/chosen/

 // frame IDs. It is also less than half of the full 8-bits range such that we
 // can handle wrap around and compare two frame IDs.
 const int kMaxUnackedFrames = 120;
+const int kMinUnackedFrequency = 8000;

[IrfanGoogle, 2015/09/14 17:52:32]

Comment here

[miu, 2015/09/14 17:55:08]

This is not the meaning of this value.  See comment above.

[msu.koo, 2015/09/15 00:05:06]

Done.

Thank you for your comments, this change is reverted.

 
 const int64 kCastMessageUpdateIntervalMs = 33;
 const int64 kNackRepeatIntervalMs = 30;
 
 // Success/in-progress/failure status codes bubbled up to clients via
 // StatusChangeCallbacks.
 enum OperationalStatus {
   // Client should not send frames yet (sender), or should not expect to receive
   // frames yet (receiver).
   STATUS_UNINITIALIZED,
@@ skipping 167 matching lines @@
 
 inline int64 TimeDeltaToRtpDelta(base::TimeDelta delta, int rtp_timebase) {
   DCHECK_GT(rtp_timebase, 0);
   return delta * rtp_timebase / base::TimeDelta::FromSeconds(1);
 }
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_CAST_DEFINES_H_