sandbox/win/src/restricted_token.cc - Issue 1337223002: Fixes to possible GetLastError bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/restricted_token.cc

Issue 1337223002: Fixes to possible GetLastError bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed some sandbox changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/restricted_token.cc

diff --git a/sandbox/win/src/restricted_token.cc b/sandbox/win/src/restricted_token.cc

index df5a87ccf0c0e60c0c4dcd6f9bfffb03705e271b..f0fc4cbc37df144fc2f1899181f309ecdf3f91bf 100644

--- a/sandbox/win/src/restricted_token.cc

+++ b/sandbox/win/src/restricted_token.cc

@@ -140,6 +140,7 @@ DWORD RestrictedToken::GetRestrictedToken(

SecurityIdentification, TokenPrimary,

&new_token_handle);

}

+ auto last_error = ::GetLastError();

if (deny_only_array)

delete[] deny_only_array;

@@ -151,7 +152,7 @@ DWORD RestrictedToken::GetRestrictedToken(

delete[] privileges_to_disable_array;

if (!result)

- return ::GetLastError();

+ return last_error;

base::win::ScopedHandle new_token(new_token_handle);