base/debug/stack_trace_win.cc - Issue 1337223002: Fixes to possible GetLastError bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace_win.cc

Issue 1337223002: Fixes to possible GetLastError bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed some sandbox changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/stack_trace_win.cc

diff --git a/base/debug/stack_trace_win.cc b/base/debug/stack_trace_win.cc

index 94c2e967363c218a0d7f875bf2657290ab033cab..d5be5efb3558a1fcedba409e72b6f23efde840b2 100644

--- a/base/debug/stack_trace_win.cc

+++ b/base/debug/stack_trace_win.cc

@@ -77,8 +77,8 @@ bool InitializeSymbols() {

if (!SymGetSearchPathW(GetCurrentProcess(),

symbols_path.get(),

kSymbolsArraySize)) {

- DLOG(WARNING) << "SymGetSearchPath failed: " << g_init_error;

g_init_error = GetLastError();

+ DLOG(WARNING) << "SymGetSearchPath failed: " << g_init_error;

return false;

}

« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager_util_win.cc » ('j') | no next file with comments »