sandbox/win/src/restricted_token_utils.cc - Issue 1337223002: Fixes to possible GetLastError bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/restricted_token_utils.cc

Issue 1337223002: Fixes to possible GetLastError bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/restricted_token_utils.cc

diff --git a/sandbox/win/src/restricted_token_utils.cc b/sandbox/win/src/restricted_token_utils.cc

index 7f70e88e8fd6e2ffa13b3547a4de2305b2d39ac5..4a3d05c639bcd5acbfff79ce2a96df946fc56ce7 100644

--- a/sandbox/win/src/restricted_token_utils.cc

+++ b/sandbox/win/src/restricted_token_utils.cc

@@ -218,9 +218,10 @@ DWORD SetTokenIntegrityLevel(HANDLE token, IntegrityLevel integrity_level) {

DWORD size = sizeof(TOKEN_MANDATORY_LABEL) + ::GetLengthSid(integrity_sid);

BOOL result = ::SetTokenInformation(token, TokenIntegrityLevel, &label,

size);

+ auto last_error = ::GetLastError();

brucedawson 2015/09/12 00:33:55 Latch LastError before LocalFree. Probably doesn't

::LocalFree(integrity_sid);

- return result ? ERROR_SUCCESS : ::GetLastError();

+ return result ? ERROR_SUCCESS : last_error;

}

DWORD SetProcessIntegrityLevel(IntegrityLevel integrity_level) {