Issue 13372002: Uninstall a non-syncfs extension should not cause Token loss

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13372002: Uninstall a non-syncfs extension should not cause Token loss (Closed)

Created:
7 years, 8 months ago by kinuko

Modified:
7 years, 8 months ago

Reviewers:
calvinlo, nhiroki, tzik

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Uninstall a non-syncfs extension should not cause Token loss BUG=225197 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191493

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/sync_file_system/drive_file_sync_service.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

kinuko

I'm testing this fix now, but this one seems like a P0-ish issue from syncfs ...

7 years, 8 months ago (2013-03-30 02:07:55 UTC) #1

nhiroki

LGTM!! (Actually I hit the same issue when I try to fix http://crbug.com/223717)

7 years, 8 months ago (2013-03-30 02:41:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/13372002/1

7 years, 8 months ago (2013-03-30 02:52:24 UTC) #3

kinuko

Committed patchset #1 manually as r191493 (presubmit successful).

7 years, 8 months ago (2013-03-30 05:19:59 UTC) #5

Message was sent while issue was closed.

LGTM