content/browser/fileapi/upload_blob_element_reader_unittest.cc - Issue 1337153002: [Blob] BlobReader class & tests, and removal of all redundant reading.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/fileapi/upload_blob_element_reader_unittest.cc

Issue 1337153002: [Blob] BlobReader class & tests, and removal of all redundant reading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asan fix Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/fileapi/blob_reader_unittest.cc ('K') | « content/browser/fileapi/blob_url_request_job_unittest.cc ('k') | content/browser/loader/upload_data_stream_builder.h » ('j') | content/browser/loader/upload_data_stream_builder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // TODO: Insert description here. (generated by dmurph)

	2

	3 #include "storage/browser/blob/upload_blob_element_reader.h"

	4

	5 #include "testing/base/public/gunit.h"

	6

	7 namespace storage {

	8 namespace {

	9

	10 TEST(UploadBlobElementReader, Test1) {
	michaeln 2015/09/23 18:52:46 either add real tests or dont add the file either add real tests or dont add the file dmurph 2015/09/25 17:11:43 Deleted. I forgot this was here. Since the file i Show quoted text On 2015/09/23 at 18:52:46, michaeln wrote: > either add real tests or dont add the file Deleted. I forgot this was here. Since the file is basically just delegating, I don't think we need tests.
	11 // TODO(dmurph): Auto-generated test stub

	12 }

	13

	14 } // namespace

	15 } // namespace storage

OLD	NEW