win: Fix OpenProcess(PROCESS_ALL_ACCESS, ...) on XP

util/win/xp_compat.h

Index: util/win/xp_compat.h
diff --git a/util/win/xp_compat.h b/util/win/xp_compat.h
new file mode 100644
index 0000000000000000000000000000000000000000..00d1d4c30d87c8ac8cdac1a75a01ccb623d1ef42
--- /dev/null
+++ b/util/win/xp_compat.h
@@ -0,0 +1,31 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#ifndef CRASHPAD_UTIL_WIN_XP_COMPAT_H_
+#define CRASHPAD_UTIL_WIN_XP_COMPAT_H_
+
+#include <windows.h>
+
+namespace crashpad {
+
+//! \brief This is the XP-suitable value of PROCESS_ALL_ACCESS.

[Mark Mentovai, 2015/09/11 20:03:27]

`PROCESS_ALL_ACCESS`

Not sure if this makes more sense in the generated documentation if it’s inside
the enum, or if Doxygen understands the single-item enum idiom for constants.

[scottmg, 2015/09/11 20:14:28]

Done and moved inside.

+//!
+//! Requesting PROCESS_ALL_ACCESS with the value defined when building against a
+//! Vista+ SDK results in ERROR_ACCESS_DENIED when running on XP. See
+//! https://msdn.microsoft.com/en-ca/library/windows/desktop/ms684880.aspx
+enum { kXPProcessAllAccess = STANDARD_RIGHTS_REQUIRED | SYNCHRONIZE | 0xFFF };

[Mark Mentovai, 2015/09/11 20:03:27]

I think the answer is no, but do we lose anything by not having 0xf000 set on
systems that support it? The only bits that adds that I see defined in the SDK
are PROCESS_{QUERY,SET}_LIMITED_INFORMATION, but you should have that sort of
access with PROCESS_{QUERY,SET}_INFORMATION which is included in
kXPProcessAllAccess.

[scottmg, 2015/09/11 20:14:28]

That was my understanding too. I guess as long as the tests are OK, we should be
fine in any case.

+
+}  // namespace crashpad
+
+#endif  // CRASHPAD_UTIL_WIN_XP_COMPAT_H_