Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1337113008: Subzero: Don't contract an empty node that branches to itself. (Closed)

Created:
5 years, 3 months ago by Jim Stichnoth
Modified:
5 years, 3 months ago
Reviewers:
Karl, ascull, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M src/IceCfgNode.cpp View 1 chunk +5 lines, -1 line 0 comments Download
A tests_lit/llvm2ice_tests/contract.ll View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 3 months ago (2015-09-15 06:23:40 UTC) #2
ascull
lgtm
5 years, 3 months ago (2015-09-15 16:01:53 UTC) #3
Jim Stichnoth
5 years, 3 months ago (2015-09-15 17:06:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1921fba6cf3997787f7821d8fbf72b71f0342ae9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698