Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: net/quic/quic_session_test.cc

Issue 1337113006: relnote: Deprecate FLAGS_exact_stream_id_delta, which has always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/tools/quic/quic_server_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index d7dae9fb2bde5b0b6c890af79ccd203bf44cb2af..3d218a4dc014d3739bbefc1af93dda28ce3a40ef 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -330,15 +330,9 @@ TEST_P(QuicSessionTestServer, MaximumImplicitlyOpenedStreams) {
TEST_P(QuicSessionTestServer, TooManyImplicitlyOpenedStreams) {
QuicStreamId stream_id1 = kClientDataStreamId1;
// A stream ID which is too large to create.
- const QuicStreamId kMaxStreamIdDelta = 200;
- QuicStreamId stream_id2 =
- FLAGS_exact_stream_id_delta
- ? stream_id1 + 2 * session_.get_max_open_streams()
- : stream_id1 + kMaxStreamIdDelta + 2;
+ QuicStreamId stream_id2 = stream_id1 + 2 * session_.get_max_open_streams();
EXPECT_NE(nullptr, session_.GetIncomingDynamicStream(stream_id1));
- EXPECT_CALL(*connection_, SendConnectionClose(FLAGS_exact_stream_id_delta
- ? QUIC_TOO_MANY_OPEN_STREAMS
- : QUIC_INVALID_STREAM_ID));
+ EXPECT_CALL(*connection_, SendConnectionClose(QUIC_TOO_MANY_OPEN_STREAMS));
EXPECT_EQ(nullptr, session_.GetIncomingDynamicStream(stream_id2));
}
@@ -349,8 +343,7 @@ TEST_P(QuicSessionTestServer, ManyImplicitlyOpenedStreams) {
QuicStreamId stream_id = kClientDataStreamId1;
// Create one stream.
session_.GetIncomingDynamicStream(stream_id);
- EXPECT_CALL(*connection_, SendConnectionClose(_))
- .Times(FLAGS_exact_stream_id_delta ? 0 : 1);
+ EXPECT_CALL(*connection_, SendConnectionClose(_)).Times(0);
// Create the largest stream ID of a threatened total of 200 streams.
session_.GetIncomingDynamicStream(stream_id + 2 * (200 - 1));
}
@@ -629,9 +622,7 @@ TEST_P(QuicSessionTestServer, MultipleRstStreamsCauseSingleConnectionClose) {
// Process first invalid stream reset, resulting in the connection being
// closed.
- EXPECT_CALL(*connection_, SendConnectionClose(FLAGS_exact_stream_id_delta
- ? QUIC_TOO_MANY_OPEN_STREAMS
- : QUIC_INVALID_STREAM_ID))
+ EXPECT_CALL(*connection_, SendConnectionClose(QUIC_TOO_MANY_OPEN_STREAMS))
.Times(1);
const QuicStreamId kLargeInvalidStreamId = 99999999;
QuicRstStreamFrame rst1(kLargeInvalidStreamId, QUIC_STREAM_NO_ERROR, 0);
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/tools/quic/quic_server_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698