DescriptionRevert of Export various dbus::Property template specializations. (patchset #2 id:20001 of https://codereview.chromium.org/1339763003/ )
Reason for revert:
Does not compile with component=shared_library with CrOS compiler
../../dbus/property.h:437:42: error: type attributes ignored after type is already defined [-Werror=attributes]
extern template class CHROME_DBUS_EXPORT Property<uint8>;
^
../../dbus/property.h:447:42: error: type attributes ignored after type is already defined [-Werror=attributes]
extern template class CHROME_DBUS_EXPORT Property<bool>;
Repro steps:
cros chrome-sdk --board=amd64-generic --component
gclient runhooks
ninja -C out_amd64-generic/Release dbus
Original issue's description:
> Export various dbus::Property template specializations.
>
> BUG=409111
> R=stevenjb@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/40855d43fa71c215829b53a1034b1b653b4b8557
TBR=stevenjb@chromium.org,thakis@chromium.org,dcheng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=409111
Committed: https://crrev.com/95f15875106062c4dd3c5927be7f6ee5775eb78a
Cr-Commit-Position: refs/heads/master@{#348651}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|