Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1337113005: Revert of Export various dbus::Property template specializations. (Closed)

Created:
5 years, 3 months ago by spang
Modified:
5 years, 3 months ago
Reviewers:
stevenjb, Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@widget-fun
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Export various dbus::Property template specializations. (patchset #2 id:20001 of https://codereview.chromium.org/1339763003/ ) Reason for revert: Does not compile with component=shared_library with CrOS compiler ../../dbus/property.h:437:42: error: type attributes ignored after type is already defined [-Werror=attributes] extern template class CHROME_DBUS_EXPORT Property<uint8>; ^ ../../dbus/property.h:447:42: error: type attributes ignored after type is already defined [-Werror=attributes] extern template class CHROME_DBUS_EXPORT Property<bool>; Repro steps: cros chrome-sdk --board=amd64-generic --component gclient runhooks ninja -C out_amd64-generic/Release dbus Original issue's description: > Export various dbus::Property template specializations. > > BUG=409111 > R=stevenjb@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/40855d43fa71c215829b53a1034b1b653b4b8557 TBR=stevenjb@chromium.org,thakis@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=409111 Committed: https://crrev.com/95f15875106062c4dd3c5927be7f6ee5775eb78a Cr-Commit-Position: refs/heads/master@{#348651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -142 lines) Patch
M dbus/property.h View 1 chunk +86 lines, -142 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
spang
Created Revert of Export various dbus::Property template specializations.
5 years, 3 months ago (2015-09-14 17:46:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337113005/1
5 years, 3 months ago (2015-09-14 17:48:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337113005/1
5 years, 3 months ago (2015-09-14 17:49:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 17:49:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95f15875106062c4dd3c5927be7f6ee5775eb78a Cr-Commit-Position: refs/heads/master@{#348651}
5 years, 3 months ago (2015-09-14 17:50:20 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:34:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95f15875106062c4dd3c5927be7f6ee5775eb78a
Cr-Commit-Position: refs/heads/master@{#348651}

Powered by Google App Engine
This is Rietveld 408576698