Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: net/base/network_delegate_impl.h

Issue 1337113004: CHECK that URLRequestJobs are not orphaned while blocked by extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/network_delegate_impl.h
diff --git a/net/base/network_delegate_impl.h b/net/base/network_delegate_impl.h
index 7a2318899396d99f87e537fa9346838016ddd447..84e898d2a636e4d1c560b9de25908ee326091ed4 100644
--- a/net/base/network_delegate_impl.h
+++ b/net/base/network_delegate_impl.h
@@ -138,6 +138,13 @@ class NET_EXPORT NetworkDelegateImpl : public NetworkDelegate {
// a virtual method call.
void OnURLRequestDestroyed(URLRequest* request) override;
+ // Called when the current job for |request| is orphaned. This is a temporary
+ // callback to diagnose https://crbug.com/289715 and may not be used for other
+ // purposes. Note that it may be called after OnURLRequestDestroyed.
+ //
+ // TODO(davidben): Remove this once data has been gathered.
+ void OnURLRequestJobOrphaned(URLRequest* request) override;
+
// Corresponds to ProxyResolverJSBindings::OnError.
void OnPACScriptError(int line_number, const base::string16& error) override;

Powered by Google App Engine
This is Rietveld 408576698