Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1337063002: Rename LayoutSVGTransformableContainer::m_lastTranslation (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, krit, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename LayoutSVGTransformableContainer::m_lastTranslation To m_additionalTranslation, since 'last' is ambiguous. The 'additional' is from spec wording: "An additional transformation translate(x,y) ...". Committed: https://crrev.com/d08d007eb06c09515e72c2ec5fe4659ad7082443 git-svn-id: svn://svn.chromium.org/blink/trunk@202147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/layout/svg/LayoutSVGTransformableContainer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGTransformableContainer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
fs
As suggested by pdr in https://codereview.chromium.org/1310873004/
5 years, 3 months ago (2015-09-11 15:13:34 UTC) #2
f(malita)
lgtm
5 years, 3 months ago (2015-09-11 15:14:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337063002/1
5 years, 3 months ago (2015-09-11 15:14:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/112317)
5 years, 3 months ago (2015-09-11 16:34:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337063002/1
5 years, 3 months ago (2015-09-11 16:36:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202147
5 years, 3 months ago (2015-09-11 17:27:46 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:25 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d08d007eb06c09515e72c2ec5fe4659ad7082443

Powered by Google App Engine
This is Rietveld 408576698