Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 133703002: Compatible handling of the form.autocomplete IDL attribute. (Closed)

Created:
6 years, 11 months ago by sof
Modified:
6 years, 11 months ago
Reviewers:
tkent, kojih
CC:
blink-reviews, watchdog-blink-watchlist_google.com, dglazkov+blink, arv+blink, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Compatible handling of the form.autocomplete IDL attribute. Align with the spec and Gecko for the enumerated attribute 'autocomplete' over form elements. That is, map both missing and invalid content attribute values to the "on" keyword/string. R= BUG=333229 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165043

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/autocomplete.html View 2 chunks +9 lines, -10 lines 3 comments Download
M LayoutTests/fast/forms/autocomplete-expected.txt View 1 chunk +10 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look when you next have a moment. Aligning with spec. In terms ...
6 years, 11 months ago (2014-01-10 13:13:48 UTC) #1
tkent
https://codereview.chromium.org/133703002/diff/1/LayoutTests/fast/forms/autocomplete.html File LayoutTests/fast/forms/autocomplete.html (right): https://codereview.chromium.org/133703002/diff/1/LayoutTests/fast/forms/autocomplete.html#newcode5 LayoutTests/fast/forms/autocomplete.html:5: window.jsTestIsAsync = true; Why?
6 years, 11 months ago (2014-01-14 00:35:33 UTC) #2
sof
https://codereview.chromium.org/133703002/diff/1/LayoutTests/fast/forms/autocomplete.html File LayoutTests/fast/forms/autocomplete.html (right): https://codereview.chromium.org/133703002/diff/1/LayoutTests/fast/forms/autocomplete.html#newcode5 LayoutTests/fast/forms/autocomplete.html:5: window.jsTestIsAsync = true; On 2014/01/14 00:35:33, tkent wrote: > ...
6 years, 11 months ago (2014-01-14 06:39:47 UTC) #3
tkent
lgtm https://codereview.chromium.org/133703002/diff/1/LayoutTests/fast/forms/autocomplete.html File LayoutTests/fast/forms/autocomplete.html (right): https://codereview.chromium.org/133703002/diff/1/LayoutTests/fast/forms/autocomplete.html#newcode5 LayoutTests/fast/forms/autocomplete.html:5: window.jsTestIsAsync = true; On 2014/01/14 06:39:48, sof wrote: ...
6 years, 11 months ago (2014-01-14 06:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/133703002/1
6 years, 11 months ago (2014-01-14 07:02:06 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 08:34:17 UTC) #6
Message was sent while issue was closed. 
Change committed as 165043

Powered by Google App Engine
This is Rietveld 408576698