Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1337023002: MIPS: Save and restore callee-saved FP registers in cctest/ConvertDToI. (Closed)

Created:
5 years, 3 months ago by akos.palfi.imgtec
Modified:
5 years, 3 months ago
Reviewers:
balazs.kilvady, ilija.pavlovic, paul.l...
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Save and restore callee-saved FP registers in cctest/ConvertDToI. Correctly save and restore FP registers in cctest/ConvertDToI to avoid accidental register overwriting by the generated code. Note: This failure is manifested only in R6 mode. TEST=test/cctest/interpreter/test-interpreter BUG= Committed: https://crrev.com/a795aa350f4d62ccbd8ea2ec297e1d844229ba4a Cr-Commit-Position: refs/heads/master@{#30700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M test/cctest/test-code-stubs-mips.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 3 months ago (2015-09-11 14:11:16 UTC) #2
paul.l...
lgtm
5 years, 3 months ago (2015-09-11 14:52:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337023002/1
5 years, 3 months ago (2015-09-11 15:09:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 15:31:14 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 15:31:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a795aa350f4d62ccbd8ea2ec297e1d844229ba4a
Cr-Commit-Position: refs/heads/master@{#30700}

Powered by Google App Engine
This is Rietveld 408576698