Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336933003: [Migrated][Fetch] Support blob: scheme (Closed)

Created:
5 years, 3 months ago by hiroshige
Modified:
5 years, 2 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Migrated to https://codereview.chromium.org/1371393003/. [Fetch] Support blob: scheme The following are not spec conformant: - Redirects to blob: URLs are rejected. BUG=521466

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add tests for rejecting non-GET methods. #

Patch Set 4 : Network Error for non-GET blob URLs. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -16 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/fetch.js View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/script-tests/thorough/scheme-blob.js View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/scheme-blob.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/scheme-blob-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker-proxied/thorough/scheme-blob-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/serviceworker/thorough/scheme-blob-other-https.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/http/tests/fetch/window/thorough/scheme-blob.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/thorough/scheme-blob-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/window/thorough/scheme-blob-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/thorough/scheme-blob.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/thorough/scheme-blob-base-https-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/fetch/workers/thorough/scheme-blob-other-https.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/FetchManager.cpp View 1 2 3 3 chunks +16 lines, -1 line 1 comment Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336933003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336933003/20001
5 years, 3 months ago (2015-09-11 10:45:48 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 12:07:06 UTC) #4
hiroshige
PTAL. Do we need chromestatus entry and/or intent to ship?
5 years, 3 months ago (2015-09-14 05:24:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336933003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336933003/40001
5 years, 3 months ago (2015-09-15 10:27:58 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336933003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336933003/60001
5 years, 3 months ago (2015-09-15 10:38:32 UTC) #10
hiroshige
About non-GET methods, I expect the spec is updated so that non-GET method is rejected. ...
5 years, 3 months ago (2015-09-15 10:40:05 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/53024)
5 years, 3 months ago (2015-09-15 11:48:50 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336933003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336933003/60001
5 years, 3 months ago (2015-09-15 11:50:48 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 12:24:28 UTC) #17
yhirano
https://codereview.chromium.org/1336933003/diff/60001/Source/modules/fetch/FetchManager.cpp File Source/modules/fetch/FetchManager.cpp (right): https://codereview.chromium.org/1336933003/diff/60001/Source/modules/fetch/FetchManager.cpp#newcode213 Source/modules/fetch/FetchManager.cpp:213: // TODO(hiroshige): Spec will be updated https://github.com/whatwg/fetch/issues/125. Update this ...
5 years, 2 months ago (2015-10-06 05:02:02 UTC) #18
yhirano
5 years, 2 months ago (2015-10-06 05:02:25 UTC) #19
Message was sent while issue was closed. 
On 2015/10/06 05:02:02, yhirano wrote:
>
https://codereview.chromium.org/1336933003/diff/60001/Source/modules/fetch/Fe...
> File Source/modules/fetch/FetchManager.cpp (right):
> 
>
https://codereview.chromium.org/1336933003/diff/60001/Source/modules/fetch/Fe...
> Source/modules/fetch/FetchManager.cpp:213: // TODO(hiroshige): Spec will be
> updated https://github.com/whatwg/fetch/issues/125. Update this comment with
> citing the new spec before commit.
> The issue was closed.

Oops, never mind.

Powered by Google App Engine
This is Rietveld 408576698