Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1336923004: Revert of Add options to write version number to registry. (Closed)

Created:
5 years, 3 months ago by hans
Modified:
5 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add options to write version number to registry. (patchset #14 id:260001 of https://codereview.chromium.org/1271893003/ ) Reason for revert: This broke the Windows Clang build. The error is pointing out a real problem: ..\..\chrome\installer\setup\setup_main.cc(132,7) : error: cannot pass object of non-trivial type 'base::string16' (aka 'basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t> >') through variadic function; call will abort at runtime [-Wnon-pod-varargs] installer::GuidToSquid(product)); ^ (From http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/3152/steps/compile/logs/stdio) Original issue's description: > Add options to write version number to registry. > > The MSI installer creates a DisplayVersion registry entry > with an encoded version of Chrome's actual version. Since > this is done _after_ the setup call completes, we can't > simply set the value in the normal setup process. Instead, > we launch a background process that waits a while (for > msiexec to complete) and then writes the updated version. > > This is accomplished by having setup, upon successful completion, > run itself in the background and then exit normally. > > --set-display-version-path="SOFTWARE\...\InstallProperties" > --set-display-version-value="A.B.C.D" > --delay=30 > > BUG=67348 > > Committed: https://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733 > Cr-Commit-Position: refs/heads/master@{#348556} TBR=robertshield@chromium.org,grt@chromium.org,bcwhite@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=67348 Committed: https://crrev.com/b0e804c61f82b7e01011a6680ca2191e13844392 Cr-Commit-Position: refs/heads/master@{#348629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -176 lines) Patch
M chrome/installer/setup/setup_constants.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/installer/setup/setup_constants.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 4 chunks +10 lines, -119 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hans
Created Revert of Add options to write version number to registry.
5 years, 3 months ago (2015-09-14 16:33:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336923004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336923004/1
5 years, 3 months ago (2015-09-14 16:34:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 16:37:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b0e804c61f82b7e01011a6680ca2191e13844392 Cr-Commit-Position: refs/heads/master@{#348629}
5 years, 3 months ago (2015-09-14 16:38:02 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:33:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0e804c61f82b7e01011a6680ca2191e13844392
Cr-Commit-Position: refs/heads/master@{#348629}

Powered by Google App Engine
This is Rietveld 408576698