Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 1336923003: Revert of Remove IdleNotification call in the main thread of foreground tab. (Closed)

Created:
5 years, 3 months ago by ulan
Modified:
5 years, 3 months ago
Reviewers:
haraken, rmcilroy
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove IdleNotification call in the main thread of foreground tab. (patchset #1 id:1 of https://codereview.chromium.org/1320073005/ ) Reason for revert: Reverting because of regression in v8.top_25_smooth benchmark (crbug.com/530391) Original issue's description: > Remove IdleNotification call in the main thread of foreground tab. > > V8 posts idle tasks explicitly. > > BUG=chromium:490559 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201977 TBR=rmcilroy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:490559 Committed: https://crrev.com/d9054a96215d745e2b3e730ff67dbf0236f1b8ba git-svn-id: svn://svn.chromium.org/blink/trunk@202123 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
Created Revert of Remove IdleNotification call in the main thread of foreground tab.
5 years, 3 months ago (2015-09-11 09:24:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336923003/1
5 years, 3 months ago (2015-09-11 09:25:07 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-11 09:25:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202123
5 years, 3 months ago (2015-09-11 09:25:43 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:20:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9054a96215d745e2b3e730ff67dbf0236f1b8ba

Powered by Google App Engine
This is Rietveld 408576698