Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336853003: Request focus for re-auth webview. (Closed)

Created:
5 years, 3 months ago by gogerald1
Modified:
5 years, 3 months ago
Reviewers:
sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Request focus for re-auth webview. Request focus for re-auth webview after re-auth dialog is showing. BUG=520046 . Committed: https://crrev.com/2c05239be25ab5e7dae789f2357ae596970d2c5a Cr-Commit-Position: refs/heads/master@{#348789}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/views/profiles/user_manager_view.cc View 1 2 chunks +5 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
gogerald1
Hi Scott, Please help review this CL. Ganggui,
5 years, 3 months ago (2015-09-14 19:46:02 UTC) #2
sky
https://codereview.chromium.org/1336853003/diff/1/chrome/browser/ui/views/profiles/user_manager_view.cc File chrome/browser/ui/views/profiles/user_manager_view.cc (right): https://codereview.chromium.org/1336853003/diff/1/chrome/browser/ui/views/profiles/user_manager_view.cc#newcode77 chrome/browser/ui/views/profiles/user_manager_view.cc:77: int GetDialogButtons() const override; How about overriding GetInitiallyFocusedView?
5 years, 3 months ago (2015-09-14 21:33:06 UTC) #3
gogerald1
Much better to override GetInitiallyFocusedView, didn't notice that interface :). Thanks! https://codereview.chromium.org/1336853003/diff/1/chrome/browser/ui/views/profiles/user_manager_view.cc File chrome/browser/ui/views/profiles/user_manager_view.cc (right): ...
5 years, 3 months ago (2015-09-14 22:27:03 UTC) #4
sky
LGTM https://codereview.chromium.org/1336853003/diff/20001/chrome/browser/ui/views/profiles/user_manager_view.cc File chrome/browser/ui/views/profiles/user_manager_view.cc (right): https://codereview.chromium.org/1336853003/diff/20001/chrome/browser/ui/views/profiles/user_manager_view.cc#newcode143 chrome/browser/ui/views/profiles/user_manager_view.cc:143: return static_cast<views::View*>(web_view_); You shouldn't need the static_cast. web_view_ ...
5 years, 3 months ago (2015-09-14 22:49:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336853003/20001
5 years, 3 months ago (2015-09-14 23:38:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 00:34:15 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2c05239be25ab5e7dae789f2357ae596970d2c5a Cr-Commit-Position: refs/heads/master@{#348789}
5 years, 3 months ago (2015-09-15 00:34:49 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:11 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2c05239be25ab5e7dae789f2357ae596970d2c5a
Cr-Commit-Position: refs/heads/master@{#348789}

Powered by Google App Engine
This is Rietveld 408576698