Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 133683011: Implement nacl_irt_thread and nacl_irt_tls for non-sfi mode. (Closed)

Created:
6 years, 11 months ago by hidehiko
Modified:
6 years, 11 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, hamaji
Visibility:
Public.

Description

Implement nacl_irt_thread and nacl_irt_tls for non-sfi mode. This CL implements nacl_irt_thread and nacl_irt_tls. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734 TEST=Tried to call a newly added function from plugin via AT_SYSINFO. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245123

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
M components/nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/irt_interfaces.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/irt_interfaces.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A components/nacl/loader/nonsfi/irt_thread.cc View 1 1 chunk +126 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
6 years, 11 months ago (2014-01-15 09:50:53 UTC) #1
Mark Seaborn
LGTM https://codereview.chromium.org/133683011/diff/1/components/nacl/loader/nonsfi/irt_thread.cc File components/nacl/loader/nonsfi/irt_thread.cc (right): https://codereview.chromium.org/133683011/diff/1/components/nacl/loader/nonsfi/irt_thread.cc#newcode52 components/nacl/loader/nonsfi/irt_thread.cc:52: return NULL; Can you call abort() instead? The ...
6 years, 11 months ago (2014-01-15 19:06:39 UTC) #2
hidehiko
Thank you for your review. Submitting... https://codereview.chromium.org/133683011/diff/1/components/nacl/loader/nonsfi/irt_thread.cc File components/nacl/loader/nonsfi/irt_thread.cc (right): https://codereview.chromium.org/133683011/diff/1/components/nacl/loader/nonsfi/irt_thread.cc#newcode52 components/nacl/loader/nonsfi/irt_thread.cc:52: return NULL; On ...
6 years, 11 months ago (2014-01-16 03:17:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/133683011/100001
6 years, 11 months ago (2014-01-16 03:19:05 UTC) #4
commit-bot: I haz the power
Change committed as 245123
6 years, 11 months ago (2014-01-16 04:59:00 UTC) #5
Mark Seaborn
6 years, 11 months ago (2014-01-16 19:04:39 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/133683011/diff/100001/components/nacl/loader/...
File components/nacl/loader/nonsfi/irt_thread.cc (right):

https://codereview.chromium.org/133683011/diff/100001/components/nacl/loader/...
components/nacl/loader/nonsfi/irt_thread.cc:99: // do anything.
Nit: "doing" (I don't mind whether you fix this, but you can TBR a change for it
if you want)

Powered by Google App Engine
This is Rietveld 408576698