add more log to adb_wrapper.py Ls function

add more log to adb_wrapper.py Ls function

Android Tests (trial)(dbg) now wipes chrome specific data during
provisioning device. But some cases show that "adb ls" is not outputing
the 4-column result (e.g.,
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28trial%29%28dbg%29/builds/4693/steps/provision_devices/logs/stdio).
This CL is to add more log to the Ls function, in order to get more
detailed information of such weird cases.

BUG=514449
Committed: https://crrev.com/8c556f27a7bbabec5264952f259d65a7262fc3af
Cr-Commit-Position: refs/heads/master@{#348799}

[Menglin, 2015-09-14 20:53:26]

mlliu@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Menglin, 2015-09-14 20:53:26]

Hi John,

Please review this CL. Thank you

Menglin

[jbudorick, 2015-09-14 20:56:10]

https://codereview.chromium.org/1336823004/diff/1/build/android/devil/android...
File build/android/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/1336823004/diff/1/build/android/devil/android...
build/android/devil/android/sdk/adb_wrapper.py:322: if len(cols) < 4:
As we're dependent on this being true, we should probably raise an
AdbCommandFailedError here instead of logging at info level.

[Menglin, 2015-09-14 22:23:49]

https://codereview.chromium.org/1336823004/diff/1/build/android/devil/android...
File build/android/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/1336823004/diff/1/build/android/devil/android...
build/android/devil/android/sdk/adb_wrapper.py:322: if len(cols) < 4:
On 2015/09/14 20:56:10, jbudorick wrote:
> As we're dependent on this being true, we should probably raise an
> AdbCommandFailedError here instead of logging at info level.

Done.

[jbudorick, 2015-09-14 22:42:38]

lgtm w/ nit

https://codereview.chromium.org/1336823004/diff/20001/build/android/devil/and...
File build/android/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/1336823004/diff/20001/build/android/devil/and...
build/android/devil/android/sdk/adb_wrapper.py:325: cmd, line,
device_serial=self._device_serial)
nit: This should also have a message explaining what's happening.

[Menglin, 2015-09-14 22:53:46]

https://codereview.chromium.org/1336823004/diff/20001/build/android/devil/and...
File build/android/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/1336823004/diff/20001/build/android/devil/and...
build/android/devil/android/sdk/adb_wrapper.py:325: cmd, line,
device_serial=self._device_serial)
On 2015/09/14 22:42:38, jbudorick wrote:
> nit: This should also have a message explaining what's happening.

Done.

[Menglin, 2015-09-15 00:27:55]

The CQ bit was checked by mlliu@chromium.org

[Menglin, 2015-09-15 00:27:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1336823004/#ps40001
(title: "add a message explaining the meaning of the error")

[commit-bot: I haz the power, 2015-09-15 00:28:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336823004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336823004/40001

[commit-bot: I haz the power, 2015-09-15 01:18:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-15 01:18:54]

Patchset 3 (id:??) landed as
https://crrev.com/8c556f27a7bbabec5264952f259d65a7262fc3af
Cr-Commit-Position: refs/heads/master@{#348799}

[commit-bot: I haz the power, 2015-09-23 12:40:43]

Patchset 3 (id:??) landed as
https://crrev.com/8c556f27a7bbabec5264952f259d65a7262fc3af
Cr-Commit-Position: refs/heads/master@{#348799}