Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl
Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc
diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
index 0a26de6d63fabe3890929b1c9464dafa25f30a2b..6d444b4349da5a12ad53a5f9da47a32742ab390e 100644
--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc
@@ -197,11 +197,11 @@ TabDragController::TabDragController()
source_tabstrip_(NULL),
attached_tabstrip_(NULL),
screen_(NULL),
- host_desktop_type_(chrome::HOST_DESKTOP_TYPE_NATIVE),
+ host_desktop_type_(ui::HOST_DESKTOP_TYPE_NATIVE),
can_release_capture_(true),
offset_to_width_ratio_(0),
- old_focused_view_id_(
- views::ViewStorage::GetInstance()->CreateStorageID()),
+ old_focused_view_id_(views::ViewStorage::GetInstance()
+ ->CreateStorageID()),
last_move_screen_loc_(0),
started_drag_(false),
active_(true),
@@ -275,8 +275,7 @@ void TabDragController::Init(
#if defined(OS_LINUX)
can_release_capture_ = false;
#else
- can_release_capture_ =
- (host_desktop_type_ != chrome::HOST_DESKTOP_TYPE_ASH);
+ can_release_capture_ = (host_desktop_type_ != ui::HOST_DESKTOP_TYPE_ASH);
#endif
start_point_in_screen_ = gfx::Point(source_tab_offset, mouse_offset.y());
views::View::ConvertPointToScreen(source_tab, &start_point_in_screen_);
@@ -604,7 +603,7 @@ TabDragController::DragBrowserToNewTabStrip(
// ReleaseCapture() is going to result in calling back to us (because it
// results in a move). That'll cause all sorts of problems. Reset the
// observer so we don't get notified and process the event.
- if (host_desktop_type_ == chrome::HOST_DESKTOP_TYPE_ASH) {
+ if (host_desktop_type_ == ui::HOST_DESKTOP_TYPE_ASH) {
move_loop_widget_->RemoveObserver(this);
move_loop_widget_ = NULL;
}
@@ -1544,7 +1543,7 @@ void TabDragController::MaximizeAttachedWindow() {
GetAttachedBrowserWidget()->Maximize();
#if defined(USE_ASH)
if (was_source_fullscreen_ &&
- host_desktop_type_ == chrome::HOST_DESKTOP_TYPE_ASH) {
+ host_desktop_type_ == ui::HOST_DESKTOP_TYPE_ASH) {
// In fullscreen mode it is only possible to get here if the source
// was in "immersive fullscreen" mode, so toggle it back on.
ash::accelerators::ToggleFullscreen();
@@ -1577,7 +1576,7 @@ void TabDragController::BringWindowUnderPointToFront(
return;
#if defined(USE_ASH)
- if (host_desktop_type_ == chrome::HOST_DESKTOP_TYPE_ASH) {
+ if (host_desktop_type_ == ui::HOST_DESKTOP_TYPE_ASH) {
// TODO(varkha): The code below ensures that the phantom drag widget
// is shown on top of browser windows. The code should be moved to ash/
// and the phantom should be able to assert its top-most state on its own.
@@ -1762,7 +1761,7 @@ Browser* TabDragController::CreateBrowserForDrag(
gfx::Point TabDragController::GetCursorScreenPoint() {
#if defined(USE_ASH)
- if (host_desktop_type_ == chrome::HOST_DESKTOP_TYPE_ASH &&
+ if (host_desktop_type_ == ui::HOST_DESKTOP_TYPE_ASH &&
event_source_ == EVENT_SOURCE_TOUCH &&
aura::Env::GetInstance()->is_touch_down()) {
views::Widget* widget = GetAttachedBrowserWidget();
@@ -1810,8 +1809,8 @@ gfx::NativeWindow TabDragController::GetLocalProcessWindow(
// window which was used for dragging is not hidden once all of its tabs are
// attached to another browser window in DragBrowserToNewTabStrip().
// TODO(pkotwicz): Fix this properly (crbug.com/358482)
- BrowserList* browser_list = BrowserList::GetInstance(
- chrome::HOST_DESKTOP_TYPE_NATIVE);
+ BrowserList* browser_list =
+ BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE);
for (BrowserList::const_iterator it = browser_list->begin();
it != browser_list->end(); ++it) {
if ((*it)->tab_strip_model()->empty())

Powered by Google App Engine
This is Rietveld 408576698