chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm - Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl

Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc ('k') | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | ui/gfx/host_desktop_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

index d5734c09dc57f841662cfd01222414d820ea0376..cbc23bba4db44449ce3da8f890f3eb198b2f0693 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm

@@ -87,13 +87,11 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

// Open the URL of the given BookmarkNode in the current tab.

- (void)openURLForNode:(const BookmarkNode*)node {

- Browser* browser =

- chrome::FindTabbedBrowser(bridge_->GetProfile(),

- true,

- chrome::HOST_DESKTOP_TYPE_NATIVE);

+ Browser* browser = chrome::FindTabbedBrowser(bridge_->GetProfile(), true,

+ ui::HOST_DESKTOP_TYPE_NATIVE);

if (!browser) {

- browser = new Browser(Browser::CreateParams(

- bridge_->GetProfile(), chrome::HOST_DESKTOP_TYPE_NATIVE));

+ browser = new Browser(Browser::CreateParams(bridge_->GetProfile(),

+ ui::HOST_DESKTOP_TYPE_NATIVE));

}

WindowOpenDisposition disposition =

ui::WindowOpenDispositionFromNSEvent([NSApp currentEvent]);

@@ -111,13 +109,11 @@ const NSUInteger kMaximumMenuPixelsWide = 300;

const BookmarkNode* node = [self nodeForIdentifier:identifier];

DCHECK(node);