chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm - Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl

Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_mac.mm ('k') | chrome/browser/ui/app_list/app_list_syncable_service.cc » ('j') | ui/gfx/host_desktop_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm

diff --git a/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm b/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm

index 3c99dc38f7db9742e0881a830680a5100c67fb2f..1ffd193eee8299a2e871d586a4a0ce1cc91d70fe 100644

--- a/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm

+++ b/chrome/browser/ui/app_list/app_list_service_mac_interactive_uitest.mm

@@ -90,8 +90,7 @@ IN_PROC_BROWSER_TEST_F(AppListServiceMacInteractiveTest, ShowAppListUsingShim) {

// Check that AppListService has registered as a shim handler for "app_list".

EXPECT_TRUE(AppShimHandler::GetForAppMode(app_mode::kAppListModeId));

- AppListService* service =

- AppListService::Get(chrome::HOST_DESKTOP_TYPE_NATIVE);

+ AppListService* service = AppListService::Get(ui::HOST_DESKTOP_TYPE_NATIVE);

EXPECT_FALSE(service->IsAppListVisible());

// Creation should be lazy.