chrome/browser/platform_util_chromeos.cc - Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/platform_util_chromeos.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl

Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc ('k') | chrome/browser/platform_util_win.cc » ('j') | ui/gfx/host_desktop_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/platform_util_chromeos.cc

diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc

index 077a044ccf5546f59ace81a92fa7f3a77299f871..4bf18a6f6caffbc598bab7289e07a6cfa9899b88 100644

--- a/chrome/browser/platform_util_chromeos.cc

+++ b/chrome/browser/platform_util_chromeos.cc

@@ -58,7 +58,7 @@ void ShowWarningOnOpenOperationResult(Profile* profile,

}

Browser* browser =

- chrome::FindTabbedBrowser(profile, false, chrome::HOST_DESKTOP_TYPE_ASH);

+ chrome::FindTabbedBrowser(profile, false, ui::HOST_DESKTOP_TYPE_ASH);

chrome::ShowMessageBox(

browser ? browser->window()->GetNativeWindow() : nullptr,

l10n_util::GetStringFUTF16(IDS_FILE_BROWSER_ERROR_VIEWING_FILE_TITLE,

@@ -109,7 +109,7 @@ void OpenExternal(Profile* profile, const GURL& url) {

// As such we should keep this code here.

chrome::NavigateParams params(profile, url, ui::PAGE_TRANSITION_LINK);

params.disposition = NEW_FOREGROUND_TAB;

- params.host_desktop_type = chrome::HOST_DESKTOP_TYPE_ASH;

+ params.host_desktop_type = ui::HOST_DESKTOP_TYPE_ASH;

if (url.SchemeIs("mailto")) {

std::string string_url = kGmailComposeUrl;