chrome/browser/extensions/bookmark_app_helper.cc - Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl

Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('k') | chrome/browser/extensions/bundle_installer.h » ('j') | ui/gfx/host_desktop_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/bookmark_app_helper.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc

index bb52f29978bf063e54f4a5c1c8ebaed24bb08922..f07ad30f3518c83e92537346f2694d600f1e1a6a 100644

--- a/chrome/browser/extensions/bookmark_app_helper.cc

+++ b/chrome/browser/extensions/bookmark_app_helper.cc

@@ -688,8 +688,8 @@ void BookmarkAppHelper::FinishInstallation(const Extension* extension) {

// On Mac, shortcuts are automatically created for hosted apps when they are

// installed, so there is no need to create them again.

#if !defined(OS_MACOSX)

- chrome::HostDesktopType desktop = browser->host_desktop_type();

- if (desktop != chrome::HOST_DESKTOP_TYPE_ASH) {

+ ui::HostDesktopType desktop = browser->host_desktop_type();

+ if (desktop != ui::HOST_DESKTOP_TYPE_ASH) {

web_app::ShortcutLocations creation_locations;

#if defined(OS_LINUX)

creation_locations.on_desktop = true;