Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl
Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest.cc » ('j') | ui/gfx/host_desktop_type.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 0b290319d87e3800626160965fe15b718cc8b9a5..c410312f366cde495fa0eef7102b5594dc445cac 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -126,7 +126,7 @@ bool g_is_opening_new_window = false;
Browser* ActivateBrowser(Profile* profile) {
Browser* browser = chrome::FindLastActiveWithProfile(
profile->IsGuestSession() ? profile->GetOffTheRecordProfile() : profile,
- chrome::HOST_DESKTOP_TYPE_NATIVE);
+ ui::HOST_DESKTOP_TYPE_NATIVE);
if (browser)
browser->window()->Activate();
return browser;
@@ -137,7 +137,7 @@ Browser* ActivateBrowser(Profile* profile) {
Browser* CreateBrowser(Profile* profile) {
{
base::AutoReset<bool> auto_reset_in_run(&g_is_opening_new_window, true);
- chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE);
+ chrome::NewEmptyWindow(profile, ui::HOST_DESKTOP_TYPE_NATIVE);
}
Browser* browser = chrome::GetLastActiveBrowser();
@@ -535,9 +535,9 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
- (void)didEndMainMessageLoop {
DCHECK_EQ(0u, chrome::GetBrowserCount([self lastProfile],
- chrome::HOST_DESKTOP_TYPE_NATIVE));
+ ui::HOST_DESKTOP_TYPE_NATIVE));
if (!chrome::GetBrowserCount([self lastProfile],
- chrome::HOST_DESKTOP_TYPE_NATIVE)) {
+ ui::HOST_DESKTOP_TYPE_NATIVE)) {
// As we're shutting down, we need to nuke the TabRestoreService, which
// will start the shutdown of the NavigationControllers and allow for
// proper shutdown. If we don't do this, Chrome won't shut down cleanly,
@@ -778,7 +778,7 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
startupComplete_ = YES;
Browser* browser =
- FindLastActiveWithHostDesktopType(chrome::HOST_DESKTOP_TYPE_NATIVE);
+ chrome::FindLastActiveWithHostDesktopType(ui::HOST_DESKTOP_TYPE_NATIVE);
content::WebContents* activeWebContents = nullptr;
if (browser)
activeWebContents = browser->tab_strip_model()->GetActiveWebContents();
@@ -854,10 +854,10 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
// Create a new browser window (if necessary) and navigate to the
// downloads page if the user chooses to wait.
Browser* browser = chrome::FindBrowserWithProfile(
- profiles[i], chrome::HOST_DESKTOP_TYPE_NATIVE);
+ profiles[i], ui::HOST_DESKTOP_TYPE_NATIVE);
if (!browser) {
- browser = new Browser(Browser::CreateParams(
- profiles[i], chrome::HOST_DESKTOP_TYPE_NATIVE));
+ browser = new Browser(
+ Browser::CreateParams(profiles[i], ui::HOST_DESKTOP_TYPE_NATIVE));
browser->window()->Show();
}
DCHECK(browser);
@@ -1074,7 +1074,7 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
case IDC_RESTORE_TAB:
// There is only the native desktop on Mac.
chrome::OpenWindowWithRestoredTabs(lastProfile,
- chrome::HOST_DESKTOP_TYPE_NATIVE);
+ ui::HOST_DESKTOP_TYPE_NATIVE);
break;
case IDC_OPEN_FILE:
chrome::ExecuteCommand(CreateBrowser(lastProfile), IDC_OPEN_FILE);
@@ -1389,8 +1389,8 @@ class AppControllerProfileObserver : public ProfileInfoCacheObserver {
Browser* browser = chrome::GetLastActiveBrowser();
// if no browser window exists then create one with no tabs to be filled in
if (!browser) {
- browser = new Browser(Browser::CreateParams(
- [self lastProfile], chrome::HOST_DESKTOP_TYPE_NATIVE));
+ browser = new Browser(Browser::CreateParams([self lastProfile],
+ ui::HOST_DESKTOP_TYPE_NATIVE));
browser->window()->Show();
}
« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest.cc » ('j') | ui/gfx/host_desktop_type.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698