Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl
Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/wrench_menu_model.h" 5 #include "chrome/browser/ui/toolbar/wrench_menu_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 base::string16 GetUpgradeDialogMenuItemName() { 97 base::string16 GetUpgradeDialogMenuItemName() {
98 if (UpgradeDetector::GetInstance()->is_outdated_install() || 98 if (UpgradeDetector::GetInstance()->is_outdated_install() ||
99 UpgradeDetector::GetInstance()->is_outdated_install_no_au()) { 99 UpgradeDetector::GetInstance()->is_outdated_install_no_au()) {
100 return l10n_util::GetStringUTF16(IDS_UPGRADE_BUBBLE_MENU_ITEM); 100 return l10n_util::GetStringUTF16(IDS_UPGRADE_BUBBLE_MENU_ITEM);
101 } else { 101 } else {
102 return l10n_util::GetStringUTF16(IDS_UPDATE_NOW); 102 return l10n_util::GetStringUTF16(IDS_UPDATE_NOW);
103 } 103 }
104 } 104 }
105 105
106 #if defined(OS_WIN) 106 #if defined(OS_WIN)
107 bool GetRestartMenuItemIfRequired(const chrome::HostDesktopType& desktop_type, 107 bool GetRestartMenuItemIfRequired(const ui::HostDesktopType& desktop_type,
108 int* command_id, 108 int* command_id,
109 int* string_id) { 109 int* string_id) {
110 if (base::win::GetVersion() == base::win::VERSION_WIN8 || 110 if (base::win::GetVersion() == base::win::VERSION_WIN8 ||
111 base::win::GetVersion() == base::win::VERSION_WIN8_1) { 111 base::win::GetVersion() == base::win::VERSION_WIN8_1) {
112 if (desktop_type != chrome::HOST_DESKTOP_TYPE_ASH) { 112 if (desktop_type != ui::HOST_DESKTOP_TYPE_ASH) {
113 *command_id = IDC_WIN8_METRO_RESTART; 113 *command_id = IDC_WIN8_METRO_RESTART;
114 *string_id = IDS_WIN8_METRO_RESTART; 114 *string_id = IDS_WIN8_METRO_RESTART;
115 } else { 115 } else {
116 *command_id = IDC_WIN_DESKTOP_RESTART; 116 *command_id = IDC_WIN_DESKTOP_RESTART;
117 *string_id = IDS_WIN_DESKTOP_RESTART; 117 *string_id = IDS_WIN_DESKTOP_RESTART;
118 } 118 }
119 return true; 119 return true;
120 } 120 }
121 121
122 // Windows 7 ASH mode is only supported in DEBUG for now. 122 // Windows 7 ASH mode is only supported in DEBUG for now.
123 #if !defined(NDEBUG) 123 #if !defined(NDEBUG)
124 // Windows 8 can support ASH mode using WARP, but Windows 7 requires a working 124 // Windows 8 can support ASH mode using WARP, but Windows 7 requires a working
125 // GPU compositor. 125 // GPU compositor.
126 if (base::win::GetVersion() == base::win::VERSION_WIN7 && 126 if (base::win::GetVersion() == base::win::VERSION_WIN7 &&
127 content::GpuDataManager::GetInstance()->CanUseGpuBrowserCompositor()) { 127 content::GpuDataManager::GetInstance()->CanUseGpuBrowserCompositor()) {
128 if (desktop_type != chrome::HOST_DESKTOP_TYPE_ASH) { 128 if (desktop_type != ui::HOST_DESKTOP_TYPE_ASH) {
129 *command_id = IDC_WIN_CHROMEOS_RESTART; 129 *command_id = IDC_WIN_CHROMEOS_RESTART;
130 *string_id = IDS_WIN_CHROMEOS_RESTART; 130 *string_id = IDS_WIN_CHROMEOS_RESTART;
131 } else { 131 } else {
132 *command_id = IDC_WIN_DESKTOP_RESTART; 132 *command_id = IDC_WIN_DESKTOP_RESTART;
133 *string_id = IDS_WIN_DESKTOP_RESTART; 133 *string_id = IDS_WIN_DESKTOP_RESTART;
134 } 134 }
135 return true; 135 return true;
136 } 136 }
137 #endif 137 #endif
138 return false; 138 return false;
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 // More tools submenu is constructed as follows: 277 // More tools submenu is constructed as follows:
278 // - Page specific actions overflow (save page, adding to taskbar). 278 // - Page specific actions overflow (save page, adding to taskbar).
279 // - Browser / OS level tools (extensions, task manager). 279 // - Browser / OS level tools (extensions, task manager).
280 // - Developer tools. 280 // - Developer tools.
281 // - Option to enable profiling. 281 // - Option to enable profiling.
282 void ToolsMenuModel::Build(Browser* browser) { 282 void ToolsMenuModel::Build(Browser* browser) {
283 bool show_create_shortcuts = true; 283 bool show_create_shortcuts = true;
284 #if defined(OS_CHROMEOS) || defined(OS_MACOSX) 284 #if defined(OS_CHROMEOS) || defined(OS_MACOSX)
285 show_create_shortcuts = false; 285 show_create_shortcuts = false;
286 #elif defined(USE_ASH) 286 #elif defined(USE_ASH)
287 if (browser->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) 287 if (browser->host_desktop_type() == ui::HOST_DESKTOP_TYPE_ASH)
288 show_create_shortcuts = false; 288 show_create_shortcuts = false;
289 #endif 289 #endif
290 AddItemWithStringId(IDC_SAVE_PAGE, IDS_SAVE_PAGE); 290 AddItemWithStringId(IDC_SAVE_PAGE, IDS_SAVE_PAGE);
291 if (extensions::util::IsNewBookmarkAppsEnabled()) { 291 if (extensions::util::IsNewBookmarkAppsEnabled()) {
292 #if defined(OS_MACOSX) 292 #if defined(OS_MACOSX)
293 int string_id = IDS_ADD_TO_APPLICATIONS; 293 int string_id = IDS_ADD_TO_APPLICATIONS;
294 #elif defined(OS_WIN) 294 #elif defined(OS_WIN)
295 int string_id = IDS_ADD_TO_TASKBAR; 295 int string_id = IDS_ADD_TO_TASKBAR;
296 #else 296 #else
297 int string_id = IDS_ADD_TO_DESKTOP; 297 int string_id = IDS_ADD_TO_DESKTOP;
298 #endif 298 #endif
299 #if defined(USE_ASH) 299 #if defined(USE_ASH)
300 if (browser->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) 300 if (browser->host_desktop_type() == ui::HOST_DESKTOP_TYPE_ASH)
301 string_id = IDS_ADD_TO_SHELF; 301 string_id = IDS_ADD_TO_SHELF;
302 #endif 302 #endif
303 AddItemWithStringId(IDC_CREATE_HOSTED_APP, string_id); 303 AddItemWithStringId(IDC_CREATE_HOSTED_APP, string_id);
304 } else if (show_create_shortcuts) { 304 } else if (show_create_shortcuts) {
305 AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS); 305 AddItemWithStringId(IDC_CREATE_SHORTCUTS, IDS_CREATE_SHORTCUTS);
306 } 306 }
307 307
308 AddSeparator(ui::NORMAL_SEPARATOR); 308 AddSeparator(ui::NORMAL_SEPARATOR);
309 AddItemWithStringId(IDC_CLEAR_BROWSING_DATA, IDS_CLEAR_BROWSING_DATA); 309 AddItemWithStringId(IDC_CLEAR_BROWSING_DATA, IDS_CLEAR_BROWSING_DATA);
310 AddItemWithStringId(IDC_MANAGE_EXTENSIONS, IDS_SHOW_EXTENSIONS); 310 AddItemWithStringId(IDC_MANAGE_EXTENSIONS, IDS_SHOW_EXTENSIONS);
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 int string_id = IDS_WIN_DESKTOP_RESTART; 924 int string_id = IDS_WIN_DESKTOP_RESTART;
925 if (GetRestartMenuItemIfRequired(browser_->host_desktop_type(), 925 if (GetRestartMenuItemIfRequired(browser_->host_desktop_type(),
926 &command_id, 926 &command_id,
927 &string_id)) { 927 &string_id)) {
928 AddSeparator(ui::NORMAL_SEPARATOR); 928 AddSeparator(ui::NORMAL_SEPARATOR);
929 AddItemWithStringId(command_id, string_id); 929 AddItemWithStringId(command_id, string_id);
930 } 930 }
931 #endif 931 #endif
932 bool show_exit_menu = browser_defaults::kShowExitMenuItem; 932 bool show_exit_menu = browser_defaults::kShowExitMenuItem;
933 #if defined(OS_WIN) 933 #if defined(OS_WIN)
934 if (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) 934 if (browser_->host_desktop_type() == ui::HOST_DESKTOP_TYPE_ASH)
935 show_exit_menu = false; 935 show_exit_menu = false;
936 #endif 936 #endif
937 if (show_exit_menu) { 937 if (show_exit_menu) {
938 AddSeparator(ui::NORMAL_SEPARATOR); 938 AddSeparator(ui::NORMAL_SEPARATOR);
939 AddItemWithStringId(IDC_EXIT, IDS_EXIT); 939 AddItemWithStringId(IDC_EXIT, IDS_EXIT);
940 } 940 }
941 uma_action_recorded_ = false; 941 uma_action_recorded_ = false;
942 } 942 }
943 943
944 bool WrenchMenuModel::AddGlobalErrorMenuItems() { 944 bool WrenchMenuModel::AddGlobalErrorMenuItems() {
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
1024 ->GetZoomPercent(); 1024 ->GetZoomPercent();
1025 } 1025 }
1026 zoom_label_ = l10n_util::GetStringFUTF16( 1026 zoom_label_ = l10n_util::GetStringFUTF16(
1027 IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent)); 1027 IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent));
1028 } 1028 }
1029 1029
1030 void WrenchMenuModel::OnZoomLevelChanged( 1030 void WrenchMenuModel::OnZoomLevelChanged(
1031 const content::HostZoomMap::ZoomLevelChange& change) { 1031 const content::HostZoomMap::ZoomLevelChange& change) {
1032 UpdateZoomControls(); 1032 UpdateZoomControls();
1033 } 1033 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698