Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Side by Side Diff: chrome/browser/ui/tab_contents/tab_contents_iterator_unittest.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl
Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h" 5 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
6 6
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "base/prefs/testing_pref_service.h" 8 #include "base/prefs/testing_pref_service.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/browser_shutdown.h" 10 #include "chrome/browser/browser_shutdown.h"
(...skipping 18 matching lines...) Expand all
29 size_t count = 0; 29 size_t count = 0;
30 for (TabContentsIterator iterator; !iterator.done(); iterator.Next()) 30 for (TabContentsIterator iterator; !iterator.done(); iterator.Next())
31 ++count; 31 ++count;
32 return count; 32 return count;
33 } 33 }
34 34
35 } // namespace 35 } // namespace
36 36
37 TEST_F(BrowserListTest, TabContentsIteratorVerifyCount) { 37 TEST_F(BrowserListTest, TabContentsIteratorVerifyCount) {
38 // Make sure we have 1 window to start with. 38 // Make sure we have 1 window to start with.
39 EXPECT_EQ(1U, 39 EXPECT_EQ(1U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE)->size());
40 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
41 40
42 EXPECT_EQ(0U, CountAllTabs()); 41 EXPECT_EQ(0U, CountAllTabs());
43 42
44 // Create more browsers/windows. 43 // Create more browsers/windows.
45 Browser::CreateParams native_params(profile(), 44 Browser::CreateParams native_params(profile(), ui::HOST_DESKTOP_TYPE_NATIVE);
46 chrome::HOST_DESKTOP_TYPE_NATIVE);
47 scoped_ptr<Browser> browser2( 45 scoped_ptr<Browser> browser2(
48 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 46 chrome::CreateBrowserWithTestWindowForParams(&native_params));
49 // Create browser 3 and 4 on the Ash desktop (the TabContentsIterator 47 // Create browser 3 and 4 on the Ash desktop (the TabContentsIterator
50 // shouldn't see the difference). 48 // shouldn't see the difference).
51 Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH); 49 Browser::CreateParams ash_params(profile(), ui::HOST_DESKTOP_TYPE_ASH);
52 scoped_ptr<Browser> browser3( 50 scoped_ptr<Browser> browser3(
53 chrome::CreateBrowserWithTestWindowForParams(&ash_params)); 51 chrome::CreateBrowserWithTestWindowForParams(&ash_params));
54 scoped_ptr<Browser> browser4( 52 scoped_ptr<Browser> browser4(
55 chrome::CreateBrowserWithTestWindowForParams(&ash_params)); 53 chrome::CreateBrowserWithTestWindowForParams(&ash_params));
56 54
57 // Sanity checks. 55 // Sanity checks.
58 #if defined(OS_CHROMEOS) 56 #if defined(OS_CHROMEOS)
59 // The ash desktop is the native desktop on Chrome OS. 57 // The ash desktop is the native desktop on Chrome OS.
60 EXPECT_EQ(4U, 58 EXPECT_EQ(4U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE)->size());
61 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
62 #else 59 #else
63 EXPECT_EQ(2U, 60 EXPECT_EQ(2U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE)->size());
64 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size()); 61 EXPECT_EQ(2U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_ASH)->size());
65 EXPECT_EQ(2U,
66 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH)->size());
67 #endif 62 #endif
68 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 63 EXPECT_EQ(0, browser()->tab_strip_model()->count());
69 EXPECT_EQ(0, browser2->tab_strip_model()->count()); 64 EXPECT_EQ(0, browser2->tab_strip_model()->count());
70 EXPECT_EQ(0, browser3->tab_strip_model()->count()); 65 EXPECT_EQ(0, browser3->tab_strip_model()->count());
71 EXPECT_EQ(0, browser4->tab_strip_model()->count()); 66 EXPECT_EQ(0, browser4->tab_strip_model()->count());
72 67
73 EXPECT_EQ(0U, CountAllTabs()); 68 EXPECT_EQ(0U, CountAllTabs());
74 69
75 // Add some tabs. 70 // Add some tabs.
76 for (size_t i = 0; i < 3; ++i) 71 for (size_t i = 0; i < 3; ++i)
(...skipping 11 matching lines...) Expand all
88 for (size_t i = 0; i < 41; ++i) 83 for (size_t i = 0; i < 41; ++i)
89 chrome::NewTab(browser()); 84 chrome::NewTab(browser());
90 85
91 EXPECT_EQ(42U, CountAllTabs()); 86 EXPECT_EQ(42U, CountAllTabs());
92 // Close all remaining tabs to keep all the destructors happy. 87 // Close all remaining tabs to keep all the destructors happy.
93 browser3->tab_strip_model()->CloseAllTabs(); 88 browser3->tab_strip_model()->CloseAllTabs();
94 } 89 }
95 90
96 TEST_F(BrowserListTest, TabContentsIteratorVerifyBrowser) { 91 TEST_F(BrowserListTest, TabContentsIteratorVerifyBrowser) {
97 // Make sure we have 1 window to start with. 92 // Make sure we have 1 window to start with.
98 EXPECT_EQ(1U, 93 EXPECT_EQ(1U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE)->size());
99 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
100 94
101 // Create more browsers/windows. 95 // Create more browsers/windows.
102 Browser::CreateParams native_params(profile(), 96 Browser::CreateParams native_params(profile(), ui::HOST_DESKTOP_TYPE_NATIVE);
103 chrome::HOST_DESKTOP_TYPE_NATIVE);
104 scoped_ptr<Browser> browser2( 97 scoped_ptr<Browser> browser2(
105 chrome::CreateBrowserWithTestWindowForParams(&native_params)); 98 chrome::CreateBrowserWithTestWindowForParams(&native_params));
106 // Create browser 3 on the Ash desktop (the TabContentsIterator shouldn't see 99 // Create browser 3 on the Ash desktop (the TabContentsIterator shouldn't see
107 // the difference). 100 // the difference).
108 Browser::CreateParams ash_params(profile(), chrome::HOST_DESKTOP_TYPE_ASH); 101 Browser::CreateParams ash_params(profile(), ui::HOST_DESKTOP_TYPE_ASH);
109 scoped_ptr<Browser> browser3( 102 scoped_ptr<Browser> browser3(
110 chrome::CreateBrowserWithTestWindowForParams(&ash_params)); 103 chrome::CreateBrowserWithTestWindowForParams(&ash_params));
111 104
112 // Sanity checks. 105 // Sanity checks.
113 #if defined(OS_CHROMEOS) 106 #if defined(OS_CHROMEOS)
114 // The ash desktop is the native desktop on Chrome OS. 107 // The ash desktop is the native desktop on Chrome OS.
115 EXPECT_EQ(3U, 108 EXPECT_EQ(3U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE)->size());
116 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size());
117 #else 109 #else
118 EXPECT_EQ(2U, 110 EXPECT_EQ(2U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_NATIVE)->size());
119 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->size()); 111 EXPECT_EQ(1U, BrowserList::GetInstance(ui::HOST_DESKTOP_TYPE_ASH)->size());
120 EXPECT_EQ(1U,
121 BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH)->size());
122 #endif 112 #endif
123 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 113 EXPECT_EQ(0, browser()->tab_strip_model()->count());
124 EXPECT_EQ(0, browser2->tab_strip_model()->count()); 114 EXPECT_EQ(0, browser2->tab_strip_model()->count());
125 EXPECT_EQ(0, browser3->tab_strip_model()->count()); 115 EXPECT_EQ(0, browser3->tab_strip_model()->count());
126 116
127 EXPECT_EQ(0U, CountAllTabs()); 117 EXPECT_EQ(0U, CountAllTabs());
128 118
129 // Add some tabs. 119 // Add some tabs.
130 for (size_t i = 0; i < 3; ++i) 120 for (size_t i = 0; i < 3; ++i)
131 chrome::NewTab(browser2.get()); 121 chrome::NewTab(browser2.get());
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 testing_browser_process->SetProfileManager(profile_manager); 194 testing_browser_process->SetProfileManager(profile_manager);
205 195
206 chrome::AttemptRestart(); 196 chrome::AttemptRestart();
207 // Cancel the effects of us calling chrome::AttemptRestart. Otherwise tests 197 // Cancel the effects of us calling chrome::AttemptRestart. Otherwise tests
208 // ran after this one will fail. 198 // ran after this one will fail.
209 browser_shutdown::SetTryingToQuit(false); 199 browser_shutdown::SetTryingToQuit(false);
210 200
211 EXPECT_TRUE(testing_pref_service.GetBoolean(prefs::kWasRestarted)); 201 EXPECT_TRUE(testing_pref_service.GetBoolean(prefs::kWasRestarted));
212 testing_browser_process->SetLocalState(NULL); 202 testing_browser_process->SetLocalState(NULL);
213 } 203 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698