Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: chrome/browser/ui/ash/accelerator_commands_browsertest.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl
Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_commands.h" 5 #include "ash/accelerators/accelerator_commands.h"
6 6
7 #include "ash/ash_switches.h" 7 #include "ash/ash_switches.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "ash/wm/window_state.h" 9 #include "ash/wm/window_state.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 EXPECT_TRUE(IsInitialShowState(window_state)); 149 EXPECT_TRUE(IsInitialShowState(window_state));
150 150
151 // 2) ToggleFullscreen() should have no effect on windows which cannot be 151 // 2) ToggleFullscreen() should have no effect on windows which cannot be
152 // maximized. 152 // maximized.
153 window_state->window()->SetProperty(aura::client::kCanMaximizeKey, false); 153 window_state->window()->SetProperty(aura::client::kCanMaximizeKey, false);
154 ash::accelerators::ToggleFullscreen(); 154 ash::accelerators::ToggleFullscreen();
155 EXPECT_TRUE(IsInitialShowState(window_state)); 155 EXPECT_TRUE(IsInitialShowState(window_state));
156 156
157 // 3) Hosted apps. 157 // 3) Hosted apps.
158 Browser::CreateParams browser_create_params( 158 Browser::CreateParams browser_create_params(
159 Browser::CreateParams::CreateForApp("Test", 159 Browser::CreateParams::CreateForApp("Test", true /* trusted_source */,
160 true /* trusted_source */, 160 gfx::Rect(), browser()->profile(),
161 gfx::Rect(), 161 ui::HOST_DESKTOP_TYPE_ASH));
162 browser()->profile(),
163 chrome::HOST_DESKTOP_TYPE_ASH));
164 162
165 Browser* app_host_browser = new Browser(browser_create_params); 163 Browser* app_host_browser = new Browser(browser_create_params);
166 ASSERT_TRUE(app_host_browser->is_app()); 164 ASSERT_TRUE(app_host_browser->is_app());
167 AddBlankTabAndShow(app_host_browser); 165 AddBlankTabAndShow(app_host_browser);
168 window_state = 166 window_state =
169 ash::wm::GetWindowState(app_host_browser->window()->GetNativeWindow()); 167 ash::wm::GetWindowState(app_host_browser->window()->GetNativeWindow());
170 ASSERT_TRUE(window_state->IsActive()); 168 ASSERT_TRUE(window_state->IsActive());
171 SetToInitialShowState(window_state); 169 SetToInitialShowState(window_state);
172 EXPECT_TRUE(IsInitialShowState(window_state)); 170 EXPECT_TRUE(IsInitialShowState(window_state));
173 171
174 ash::accelerators::ToggleFullscreen(); 172 ash::accelerators::ToggleFullscreen();
175 EXPECT_TRUE(window_state->IsFullscreen()); 173 EXPECT_TRUE(window_state->IsFullscreen());
176 EXPECT_TRUE(IsInImmersiveFullscreen(window_state)); 174 EXPECT_TRUE(IsInImmersiveFullscreen(window_state));
177 175
178 ash::accelerators::ToggleFullscreen(); 176 ash::accelerators::ToggleFullscreen();
179 EXPECT_TRUE(IsInitialShowState(window_state)); 177 EXPECT_TRUE(IsInitialShowState(window_state));
180 178
181 // 4) Popup browser windows. 179 // 4) Popup browser windows.
182 browser_create_params = Browser::CreateParams( 180 browser_create_params = Browser::CreateParams(
183 Browser::TYPE_POPUP, browser()->profile(), chrome::HOST_DESKTOP_TYPE_ASH); 181 Browser::TYPE_POPUP, browser()->profile(), ui::HOST_DESKTOP_TYPE_ASH);
184 Browser* popup_browser = new Browser(browser_create_params); 182 Browser* popup_browser = new Browser(browser_create_params);
185 ASSERT_TRUE(popup_browser->is_type_popup()); 183 ASSERT_TRUE(popup_browser->is_type_popup());
186 ASSERT_FALSE(popup_browser->is_app()); 184 ASSERT_FALSE(popup_browser->is_app());
187 AddBlankTabAndShow(popup_browser); 185 AddBlankTabAndShow(popup_browser);
188 window_state = 186 window_state =
189 ash::wm::GetWindowState(popup_browser->window()->GetNativeWindow()); 187 ash::wm::GetWindowState(popup_browser->window()->GetNativeWindow());
190 ASSERT_TRUE(window_state->IsActive()); 188 ASSERT_TRUE(window_state->IsActive());
191 SetToInitialShowState(window_state); 189 SetToInitialShowState(window_state);
192 EXPECT_TRUE(IsInitialShowState(window_state)); 190 EXPECT_TRUE(IsInitialShowState(window_state));
193 191
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 CloseAppWindow(app_window); 323 CloseAppWindow(app_window);
326 } 324 }
327 } 325 }
328 326
329 INSTANTIATE_TEST_CASE_P(InitiallyRestored, 327 INSTANTIATE_TEST_CASE_P(InitiallyRestored,
330 AcceleratorCommandsPlatformAppFullscreenBrowserTest, 328 AcceleratorCommandsPlatformAppFullscreenBrowserTest,
331 Values(ui::SHOW_STATE_NORMAL)); 329 Values(ui::SHOW_STATE_NORMAL));
332 INSTANTIATE_TEST_CASE_P(InitiallyMaximized, 330 INSTANTIATE_TEST_CASE_P(InitiallyMaximized,
333 AcceleratorCommandsPlatformAppFullscreenBrowserTest, 331 AcceleratorCommandsPlatformAppFullscreenBrowserTest,
334 Values(ui::SHOW_STATE_MAXIMIZED)); 332 Values(ui::SHOW_STATE_MAXIMIZED));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698