Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 1336823003: Move chrome::HostDesktopType to ui::HostDesktopType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@base_session_service_delegate_impl
Patch Set: Fix build on Mac and CrOS Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 CloseBrowserSynchronously(browser); 321 CloseBrowserSynchronously(browser);
322 322
323 SessionServiceTestHelper helper; 323 SessionServiceTestHelper helper;
324 helper.SetService( 324 helper.SetService(
325 SessionServiceFactory::GetForProfileForSessionRestore(profile)); 325 SessionServiceFactory::GetForProfileForSessionRestore(profile));
326 helper.SetForceBrowserNotAliveWithNoWindows(true); 326 helper.SetForceBrowserNotAliveWithNoWindows(true);
327 helper.ReleaseService(); 327 helper.ReleaseService();
328 328
329 // Create a new window, which should trigger session restore. 329 // Create a new window, which should trigger session restore.
330 ui_test_utils::BrowserAddedObserver window_observer; 330 ui_test_utils::BrowserAddedObserver window_observer;
331 chrome::NewEmptyWindow(profile, chrome::HOST_DESKTOP_TYPE_NATIVE); 331 chrome::NewEmptyWindow(profile, ui::HOST_DESKTOP_TYPE_NATIVE);
332 Browser* new_browser = window_observer.WaitForSingleNewBrowser(); 332 Browser* new_browser = window_observer.WaitForSingleNewBrowser();
333 chrome::DecrementKeepAliveCount(); 333 chrome::DecrementKeepAliveCount();
334 334
335 return new_browser; 335 return new_browser;
336 } 336 }
337 337
338 std::string fake_server_address() { 338 std::string fake_server_address() {
339 return fake_server_address_; 339 return fake_server_address_;
340 } 340 }
341 341
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 CheckReloadedPageRestored(new_browser); 476 CheckReloadedPageRestored(new_browser);
477 } 477 }
478 478
479 // Test that leaving a popup open will not prevent session restore. 479 // Test that leaving a popup open will not prevent session restore.
480 IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest, 480 IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest,
481 SessionCookiesBrowserCloseWithPopupOpen) { 481 SessionCookiesBrowserCloseWithPopupOpen) {
482 // Set the startup preference to "continue where I left off" and visit a page 482 // Set the startup preference to "continue where I left off" and visit a page
483 // which stores a session cookie. 483 // which stores a session cookie.
484 StoreDataWithPage("session_cookies.html"); 484 StoreDataWithPage("session_cookies.html");
485 Browser* popup = new Browser(Browser::CreateParams( 485 Browser* popup = new Browser(Browser::CreateParams(
486 Browser::TYPE_POPUP, 486 Browser::TYPE_POPUP, browser()->profile(), ui::HOST_DESKTOP_TYPE_NATIVE));
487 browser()->profile(),
488 chrome::HOST_DESKTOP_TYPE_NATIVE));
489 popup->window()->Show(); 487 popup->window()->Show();
490 488
491 Browser* new_browser = QuitBrowserAndRestore(browser(), false); 489 Browser* new_browser = QuitBrowserAndRestore(browser(), false);
492 // The browsing session will be continued; just wait for the page to reload 490 // The browsing session will be continued; just wait for the page to reload
493 // and check the stored data. 491 // and check the stored data.
494 CheckReloadedPageRestored(new_browser); 492 CheckReloadedPageRestored(new_browser);
495 } 493 }
496 IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest, 494 IN_PROC_BROWSER_TEST_F(ContinueWhereILeftOffTest,
497 CookiesClearedOnBrowserClose) { 495 CookiesClearedOnBrowserClose) {
498 StoreDataWithPage("cookies.html"); 496 StoreDataWithPage("cookies.html");
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 NavigateAndCheckStoredData(new_browser, "session_cookies.html"); 759 NavigateAndCheckStoredData(new_browser, "session_cookies.html");
762 else 760 else
763 StoreDataWithPage(new_browser, "session_cookies.html"); 761 StoreDataWithPage(new_browser, "session_cookies.html");
764 } 762 }
765 763
766 // Tests that session cookies are not cleared when only a popup window is open. 764 // Tests that session cookies are not cleared when only a popup window is open.
767 IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest, 765 IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
768 SessionCookiesBrowserCloseWithPopupOpen) { 766 SessionCookiesBrowserCloseWithPopupOpen) {
769 StoreDataWithPage("session_cookies.html"); 767 StoreDataWithPage("session_cookies.html");
770 Browser* popup = new Browser(Browser::CreateParams( 768 Browser* popup = new Browser(Browser::CreateParams(
771 Browser::TYPE_POPUP, 769 Browser::TYPE_POPUP, browser()->profile(), ui::HOST_DESKTOP_TYPE_NATIVE));
772 browser()->profile(),
773 chrome::HOST_DESKTOP_TYPE_NATIVE));
774 popup->window()->Show(); 770 popup->window()->Show();
775 Browser* new_browser = QuitBrowserAndRestore(browser(), false); 771 Browser* new_browser = QuitBrowserAndRestore(browser(), false);
776 NavigateAndCheckStoredData(new_browser, "session_cookies.html"); 772 NavigateAndCheckStoredData(new_browser, "session_cookies.html");
777 } 773 }
778 774
779 // Tests that session cookies are cleared if the last window to close is a 775 // Tests that session cookies are cleared if the last window to close is a
780 // popup. 776 // popup.
781 IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest, 777 IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest,
782 SessionCookiesBrowserClosePopupLast) { 778 SessionCookiesBrowserClosePopupLast) {
783 StoreDataWithPage("session_cookies.html"); 779 StoreDataWithPage("session_cookies.html");
784 Browser* popup = new Browser(Browser::CreateParams( 780 Browser* popup = new Browser(Browser::CreateParams(
785 Browser::TYPE_POPUP, 781 Browser::TYPE_POPUP, browser()->profile(), ui::HOST_DESKTOP_TYPE_NATIVE));
786 browser()->profile(),
787 chrome::HOST_DESKTOP_TYPE_NATIVE));
788 popup->window()->Show(); 782 popup->window()->Show();
789 CloseBrowserSynchronously(browser()); 783 CloseBrowserSynchronously(browser());
790 Browser* new_browser = QuitBrowserAndRestore(popup, false); 784 Browser* new_browser = QuitBrowserAndRestore(popup, false);
791 if (browser_defaults::kBrowserAliveWithNoWindows) 785 if (browser_defaults::kBrowserAliveWithNoWindows)
792 NavigateAndCheckStoredData(new_browser, "session_cookies.html"); 786 NavigateAndCheckStoredData(new_browser, "session_cookies.html");
793 else 787 else
794 StoreDataWithPage(new_browser, "session_cookies.html"); 788 StoreDataWithPage(new_browser, "session_cookies.html");
795 } 789 }
796 790
797 IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest, CookiesClearedOnBrowserClose) { 791 IN_PROC_BROWSER_TEST_F(NoSessionRestoreTest, CookiesClearedOnBrowserClose) {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
840 CookieSettingsFactory::GetForProfile(new_browser->profile()) 834 CookieSettingsFactory::GetForProfile(new_browser->profile())
841 ->SetDefaultCookieSetting(CONTENT_SETTING_SESSION_ONLY); 835 ->SetDefaultCookieSetting(CONTENT_SETTING_SESSION_ONLY);
842 // ... even if background mode is active. 836 // ... even if background mode is active.
843 EnableBackgroundMode(); 837 EnableBackgroundMode();
844 new_browser = QuitBrowserAndRestore(new_browser, true); 838 new_browser = QuitBrowserAndRestore(new_browser, true);
845 StoreDataWithPage(new_browser, "cookies.html"); 839 StoreDataWithPage(new_browser, "cookies.html");
846 DisableBackgroundMode(); 840 DisableBackgroundMode();
847 new_browser = QuitBrowserAndRestore(new_browser, true); 841 new_browser = QuitBrowserAndRestore(new_browser, true);
848 StoreDataWithPage(new_browser, "cookies.html"); 842 StoreDataWithPage(new_browser, "cookies.html");
849 } 843 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698