Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2089)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336783002: Merge to XFA: Remove CJBig2_Object, CJBig2_Module, and friends. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Remove CJBig2_Object, CJBig2_Module, and friends. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1326953006 . (cherry picked from commit 70f4404e9a9e69afdfdd07715aa946f6561ce0cb) Committed: https://pdfium.googlesource.com/pdfium/+/536486822a5550de975293f7586598be5f29aaad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -523 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 2 chunks +0 lines, -28 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.h View 4 chunks +8 lines, -7 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 3 chunks +6 lines, -8 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 30 chunks +64 lines, -110 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Define.h View 2 chunks +15 lines, -9 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h View 7 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp View 64 chunks +100 lines, -149 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable_Standard.h View 1 chunk +6 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.h View 1 chunk +6 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.cpp View 6 chunks +7 lines, -9 lines 0 comments Download
D core/src/fxcodec/jbig2/JBig2_Module.h View 1 chunk +0 lines, -26 lines 0 comments Download
D core/src/fxcodec/jbig2/JBig2_Object.h View 1 chunk +0 lines, -55 lines 0 comments Download
D core/src/fxcodec/jbig2/JBig2_Object.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Segment.h View 2 chunks +5 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 2 chunks +7 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
TBR. Minor conflict in core/src/fxcodec/codec/codec_int.h due to the presence of CCodec_TiffModule on XFA.
5 years, 3 months ago (2015-09-10 23:40:38 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as 536486822a5550de975293f7586598be5f29aaad (presubmit successful).
5 years, 3 months ago (2015-09-10 23:40:52 UTC) #2
Tom Sepez
5 years, 3 months ago (2015-09-11 15:34:43 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698