Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1336763011: MD Settings: remove --enable-md-settings until it's more important (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
Reviewers:
Oren Blasberg
CC:
chromium-reviews, michaelpg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove --enable-md-settings until it's more important Right now it just confuses folks trying to view chrome://md-settings. We should re-add it when/if it actually changes what appears when chrome://settings is navigated to. R=orenb@chromium.org BUG=425627 Committed: https://crrev.com/a6cd60f267272e2b988ca75647fbdc141376ce8a Cr-Commit-Position: refs/heads/master@{#348826}

Patch Set 1 #

Patch Set 2 : also about:flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dan Beam
5 years, 3 months ago (2015-09-14 23:51:47 UTC) #1
Oren Blasberg
lgtm
5 years, 3 months ago (2015-09-15 00:02:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763011/20001
5 years, 3 months ago (2015-09-15 02:23:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 02:56:03 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a6cd60f267272e2b988ca75647fbdc141376ce8a Cr-Commit-Position: refs/heads/master@{#348826}
5 years, 3 months ago (2015-09-15 02:56:38 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:42:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6cd60f267272e2b988ca75647fbdc141376ce8a
Cr-Commit-Position: refs/heads/master@{#348826}

Powered by Google App Engine
This is Rietveld 408576698