Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336763007: fix leak in test (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tests/ImageDecodingTest.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
reed1
ptal
5 years, 3 months ago (2015-09-14 17:39:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763007/1
5 years, 3 months ago (2015-09-14 17:40:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-14 17:40:01 UTC) #5
tomhudson
SkImageGenerator is Noncopyable, but not RefCounted. Did you mean SkAutoTDelete<>? (Note many red trybots)
5 years, 3 months ago (2015-09-14 17:43:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763007/20001
5 years, 3 months ago (2015-09-14 17:46:12 UTC) #9
reed1
On 2015/09/14 17:43:06, tomhudson wrote: > SkImageGenerator is Noncopyable, but not RefCounted. > Did you ...
5 years, 3 months ago (2015-09-14 17:47:04 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 17:52:28 UTC) #12
tomhudson
lgtm PS2 LGTM
5 years, 3 months ago (2015-09-14 17:52:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336763007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336763007/20001
5 years, 3 months ago (2015-09-14 17:52:56 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 17:53:28 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8725e5366b475a1f6f7d6b64c8d29473fa920eff

Powered by Google App Engine
This is Rietveld 408576698