Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: content/child/child_thread_impl.cc

Issue 1336733002: Re-land: cc: Implement shared worker contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android build fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/child_thread_impl.cc
diff --git a/content/child/child_thread_impl.cc b/content/child/child_thread_impl.cc
index bfb1f3a21bf3d4fe20fd40242e37debfd6673457..47e2aef437fa6521cdd38cc3423354bce6c98a28 100644
--- a/content/child/child_thread_impl.cc
+++ b/content/child/child_thread_impl.cc
@@ -590,7 +590,7 @@ scoped_ptr<base::SharedMemory> ChildThreadImpl::AllocateSharedMemory(
shared_buf.reset(new base::SharedMemory);
if (!shared_buf->CreateAnonymous(buf_size)) {
NOTREACHED();
- return NULL;
+ return nullptr;
}
#else
// On POSIX, we need to ask the browser to create the shared memory for us,
@@ -602,11 +602,11 @@ scoped_ptr<base::SharedMemory> ChildThreadImpl::AllocateSharedMemory(
shared_buf.reset(new base::SharedMemory(shared_mem_handle, false));
} else {
NOTREACHED() << "Browser failed to allocate shared memory";
- return NULL;
+ return nullptr;
}
} else {
- NOTREACHED() << "Browser allocation request message failed";
- return NULL;
+ // Send is allowed to fail during shutdown. Return null in this case.
+ return nullptr;
}
#endif
return shared_buf;

Powered by Google App Engine
This is Rietveld 408576698