Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: tools/gn/bin/roll_gn.py

Issue 1336713002: Fix GN auto-roller to handle results from buildbucket-initiated jobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/bin/roll_gn.py
diff --git a/tools/gn/bin/roll_gn.py b/tools/gn/bin/roll_gn.py
index d71e209a61b0d0bbbf7aab49b49f3ad828e208d5..59a240fd01dae073b7a7e885a2d11c789fe55cc7 100644
--- a/tools/gn/bin/roll_gn.py
+++ b/tools/gn/bin/roll_gn.py
@@ -210,8 +210,6 @@ class GNRoller(object):
except Exception as _e:
raise
- TRY_JOB_RESULT_STATES = ('success', 'warnings', 'failure', 'skipped',
- 'exception', 'retry', 'pending')
try_job_results = patchset_data['try_job_results']
if not try_job_results:
print('No try jobs found on most recent patchset')
@@ -230,7 +228,9 @@ class GNRoller(object):
print('Unexpected builder: %s')
continue
- state = TRY_JOB_RESULT_STATES[int(job['result'])]
+ TRY_JOB_RESULT_STATES = ('started', 'success', 'warnings', 'failure',
+ 'skipped', 'exception', 'retry', 'pending')
+ state = TRY_JOB_RESULT_STATES[int(job['result']) + 1]
url_str = ' %s' % job['url']
build = url_str.split('/')[-1]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698