Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 1336713002: Fix GN auto-roller to handle results from buildbucket-initiated jobs. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN auto-roller to handle results from buildbucket-initiated jobs. It looks like we can get returned a try job state value of -1 now when the try jobs are run through buildbucket instead of rietveld, so this change updates the status mapping accordingly. R=brettw@chromium.org BUG= Committed: https://crrev.com/84ffc7ef400da2351d559211bcdeeba20634df54 Cr-Commit-Position: refs/heads/master@{#348266}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/gn/bin/roll_gn.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-10 21:26:40 UTC) #1
brettw
lgtm
5 years, 3 months ago (2015-09-10 22:01:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336713002/1
5 years, 3 months ago (2015-09-10 22:07:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 22:44:53 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/84ffc7ef400da2351d559211bcdeeba20634df54 Cr-Commit-Position: refs/heads/master@{#348266}
5 years, 3 months ago (2015-09-10 22:45:28 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:15:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84ffc7ef400da2351d559211bcdeeba20634df54
Cr-Commit-Position: refs/heads/master@{#348266}

Powered by Google App Engine
This is Rietveld 408576698