Issue 133663003: Fix crash due to use of null transaction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133663003: Fix crash due to use of null transaction (Closed)

Created:
6 years, 11 months ago by jkarlin

Modified:
6 years, 11 months ago

Reviewers:
jkarlin2, mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@defer_1_net

Visibility:
Public.

Didn't check if the transaction was actually created before using it, which caused a crash. The revision associated with the cl: 243568 The cl that caused the issue: cl/122453002 BUG=333132 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244174

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	net/url_request/url_request_http_job.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/133663003/1

6 years, 11 months ago (2014-01-10 12:43:36 UTC) #3

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

6 years, 11 months ago (2014-01-10 15:21:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/133663003/1

6 years, 11 months ago (2014-01-10 15:39:15 UTC) #5

Message was sent while issue was closed.

Change committed as 244174