Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js

Issue 1336623003: [MD settings] updating polymer to 1.1.13 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js
diff --git a/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js b/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js
index 735a032a53c86fac1ac19fa56b405859b6ecd1cc..98028b6ba1951aa29631b1cef1d5c79add4e839f 100644
--- a/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js
+++ b/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js
@@ -40,21 +40,13 @@ Polymer({
},
},
- /** @override */
- attached: function() {
- // HACK(dschuyler): paper-checkbox 1.0.6 will hide the label
- // if the content is empty.
- // TODO(dschuyler): rework settings checkbox to use content
- // rather than spans.
- this.$.checkbox.$.checkboxLabel.hidden = false;
- },
-
toggle: function() {
this.checked = !this.checked;
},
/** @override */
ready: function() {
+ this.ariaHidden = true;
Jeremy Klein 2015/09/10 21:19:51 Why this? Do we intentionally want to hide this ch
dschuyler 2015/09/10 21:23:05 That should not have been checked in. Thanks for
this.$.events.forward(this.$.checkbox, ['change']);
},
});
« no previous file with comments | « ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.html ('k') | ui/webui/resources/polymer_resources.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698