Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1336623003: [MD settings] updating polymer to 1.1.13 (Closed)

Created:
5 years, 3 months ago by dschuyler
Modified:
5 years, 3 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dcheng, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] updating polymer to 1.1.13 This update includes a fix for checkboxes and radio buttons that would hide the label erroneously. BUG=425627 Committed: https://crrev.com/2f9680dd148dfb21b896e4db2266df32e602160e Cr-Commit-Position: refs/heads/master@{#348574}

Patch Set 1 #

Total comments: 2

Patch Set 2 : removed mistake #

Patch Set 3 : merge from master #

Patch Set 4 : review change #

Patch Set 5 : adding missing polymer files #

Patch Set 6 : test #

Patch Set 7 : merge with master #

Patch Set 8 : changed Polymer.IronCheckedElementBehavior name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2077 lines, -1621 lines) Patch
M chrome/browser/resources/settings/on_startup_page/on_startup_page.html View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 chunk +54 lines, -59 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/font-roboto/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-autogrow-textarea/iron-autogrow-textarea-extracted.js View 2 chunks +1 line, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-behaviors/iron-control-state-extracted.js View 1 chunk +7 lines, -2 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/.bower.json View 1 chunk +45 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/.gitignore View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/bower.json View 1 chunk +36 lines, -0 lines 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/index.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/iron-checked-element-behavior.html View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/polymer/v1_0/components-chromium/iron-checked-element-behavior/iron-checked-element-behavior-extracted.js View 1 2 3 4 5 6 7 1 chunk +88 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-collapse/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js View 11 chunks +79 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-fit-behavior/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/iron-icon.html View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icon/iron-icon-extracted.js View 3 chunks +8 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-icons/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-iconset-svg/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-input/iron-input-extracted.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-media-query/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/.bower.json View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/bower.json View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-meta/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/README.md View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js View 4 chunks +12 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-pages/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-range-behavior/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-resizable-behavior/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-selector/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/more-routing/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-behaviors/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-button/.bower.json View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-button/bower.json View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-button/paper-button.html View 2 chunks +53 lines, -56 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-button/paper-button-extracted.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/.bower.json View 2 chunks +15 lines, -14 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/bower.json View 2 chunks +11 lines, -10 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.css View 1 chunk +0 lines, -152 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox.html View 2 chunks +154 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-checkbox/paper-checkbox-extracted.js View 3 chunks +29 lines, -41 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dialog/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-drawer-panel/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/README.md View 1 chunk +32 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu.html View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-extracted.js View 3 chunks +22 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/README.md View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/paper-fab.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-fab/paper-fab-extracted.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/README.md View 2 chunks +73 lines, -80 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel.css View 2 chunks +10 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel.html View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-header-panel/paper-header-panel-extracted.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-icon-button/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/.bower.json View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/bower.json View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input.html View 2 chunks +18 lines, -22 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js View 2 chunks +15 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter.html View 1 chunk +9 lines, -13 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-char-counter-extracted.js View 3 chunks +2 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html View 2 chunks +173 lines, -177 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container-extracted.js View 8 chunks +33 lines, -25 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-error.html View 1 chunk +14 lines, -18 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-error-extracted.js View 3 chunks +2 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-extracted.js View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea.html View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-textarea-extracted.js View 4 chunks +3 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-material/paper-material.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu-button/paper-menu-button-extracted.js View 6 chunks +29 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-menu/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/README.md View 1 chunk +11 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress.html View 5 chunks +57 lines, -37 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-progress/paper-progress-extracted.js View 4 chunks +42 lines, -16 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/.bower.json View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.css View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js View 3 chunks +21 lines, -34 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-radio-group/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/.bower.json View 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/bower.json View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html View 1 chunk +66 lines, -66 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple-extracted.js View 2 chunks +2 lines, -21 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/.bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/README.md View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.css View 3 chunks +5 lines, -16 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js View 2 chunks +10 lines, -17 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-spinner/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/.bower.json View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/bower.json View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tab.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tabs/paper-tab-extracted.js View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/.bower.json View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/bower.json View 2 chunks +6 lines, -5 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.css View 1 chunk +0 lines, -113 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button.html View 3 chunks +109 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toggle-button/paper-toggle-button-extracted.js View 3 chunks +2 lines, -34 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-toolbar/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tooltip/.bower.json View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tooltip/README.md View 1 chunk +26 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tooltip/bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tooltip/paper-tooltip.html View 2 chunks +37 lines, -29 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-tooltip/paper-tooltip-extracted.js View 5 chunks +89 lines, -9 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/.bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/.bower.json View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/bower.json View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/build.log View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js View 20 chunks +111 lines, -45 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-micro-extracted.js View 9 chunks +41 lines, -28 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-mini-extracted.js View 19 chunks +91 lines, -49 lines 0 comments Download
M ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js View 1 1 chunk +0 lines, -9 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 4 9 chunks +27 lines, -24 lines 0 comments Download

Messages

Total messages: 31 (13 generated)
dschuyler
5 years, 3 months ago (2015-09-10 20:49:04 UTC) #2
Jeremy Klein
https://codereview.chromium.org/1336623003/diff/1/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js File ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js (right): https://codereview.chromium.org/1336623003/diff/1/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js#newcode49 ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js:49: this.ariaHidden = true; Why this? Do we intentionally want ...
5 years, 3 months ago (2015-09-10 21:19:51 UTC) #3
dschuyler
https://codereview.chromium.org/1336623003/diff/1/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js File ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js (right): https://codereview.chromium.org/1336623003/diff/1/ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js#newcode49 ui/webui/resources/cr_elements/v1_0/cr_checkbox/cr_checkbox.js:49: this.ariaHidden = true; On 2015/09/10 21:19:51, Jeremy Klein wrote: ...
5 years, 3 months ago (2015-09-10 21:23:05 UTC) #4
Dan Beam
this is breaking the Material Design PDF UI: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105619/steps/browser_tests%20%28with%20patch%29/logs/MaterialPDFExtensionTest.Basic
5 years, 3 months ago (2015-09-10 23:36:41 UTC) #6
Jeremy Klein
lgtm
5 years, 3 months ago (2015-09-11 02:30:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336623003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336623003/80001
5 years, 3 months ago (2015-09-11 16:47:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/98711)
5 years, 3 months ago (2015-09-11 16:59:44 UTC) #11
dschuyler
Jeremy already gave an lgtm, but this needs an owner lgtm.
5 years, 3 months ago (2015-09-11 17:19:12 UTC) #13
Dan Beam
lgtm but you need third_party/polymer still we probably ought to look into putting somebody from ...
5 years, 3 months ago (2015-09-11 17:39:35 UTC) #15
michaelpg
lgtm
5 years, 3 months ago (2015-09-12 00:58:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336623003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336623003/80001
5 years, 3 months ago (2015-09-12 00:59:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/102286) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-12 04:01:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336623003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336623003/100001
5 years, 3 months ago (2015-09-13 21:58:00 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69239)
5 years, 3 months ago (2015-09-14 03:04:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336623003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336623003/120001
5 years, 3 months ago (2015-09-14 06:13:58 UTC) #28
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-14 06:29:46 UTC) #29
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/2f9680dd148dfb21b896e4db2266df32e602160e Cr-Commit-Position: refs/heads/master@{#348574}
5 years, 3 months ago (2015-09-14 06:30:48 UTC) #30
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:30:21 UTC) #31
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/2f9680dd148dfb21b896e4db2266df32e602160e
Cr-Commit-Position: refs/heads/master@{#348574}

Powered by Google App Engine
This is Rietveld 408576698