Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 13366002: Always enable the friendly pub unittest config locally. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 83e2dee339cf75d51c3a6bb3930d3fe1f6524ce0..c0efd304ad0260c7012774ff3c323d0fa775d5b3 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -45,11 +45,15 @@ import 'descriptor.dart' as d;
/// test configuration for the machine running the tests.
initConfig() {
// If we aren't running on the bots, use the human-friendly config.
- if (new Options().arguments.contains('--human')) {
+ if (!runningOnBuildbot) {
unittestConfiguration = new CommandLineConfiguration();
}
}
+/// Returns whether we're running on a Dart build bot.
+bool runningOnBuildbot =>
+ Platform.environment.containsKey('BUILDBOT_BUILDERNAME');
+
/// The current [HttpServer] created using [serve].
var _server;
@@ -399,7 +403,7 @@ void ensureGit() {
schedule(() {
return gitlib.isInstalled.then((installed) {
if (installed) return;
- if (Platform.environment.containsKey('BUILDBOT_BUILDERNAME')) return;
+ if (runningOnBuildbot) return;
currentSchedule.abort();
});
}, 'ensuring that Git is installed');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698