Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2259)

Unified Diff: content/public/test/test_launcher.cc

Issue 133653002: Clean up TestLauncherDelegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/launcher/unit_test_launcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/test_launcher.cc
diff --git a/content/public/test/test_launcher.cc b/content/public/test/test_launcher.cc
index f3fcb5ec0c906607ee1cfa1acb99619174d66c4e..c7c5f93788e3eb4b031793729cb75432b35af623 100644
--- a/content/public/test/test_launcher.cc
+++ b/content/public/test/test_launcher.cc
@@ -118,10 +118,6 @@ class WrapperTestLauncherDelegate : public base::TestLauncherDelegate {
}
// base::TestLauncherDelegate:
- virtual void OnTestIterationStarting() OVERRIDE;
- virtual std::string GetTestNameForFiltering(
- const testing::TestCase* test_case,
- const testing::TestInfo* test_info) OVERRIDE;
virtual bool ShouldRunTest(const testing::TestCase* test_case,
const testing::TestInfo* test_info) OVERRIDE;
virtual size_t RunTests(base::TestLauncher* test_launcher,
@@ -174,18 +170,6 @@ class WrapperTestLauncherDelegate : public base::TestLauncherDelegate {
DISALLOW_COPY_AND_ASSIGN(WrapperTestLauncherDelegate);
};
-void WrapperTestLauncherDelegate::OnTestIterationStarting() {
- dependent_test_map_.clear();
- user_data_dir_map_.clear();
-}
-
-std::string WrapperTestLauncherDelegate::GetTestNameForFiltering(
- const testing::TestCase* test_case,
- const testing::TestInfo* test_info) {
- return RemoveAnyPrePrefixes(
- std::string(test_case->name()) + "." + test_info->name());
-}
-
bool WrapperTestLauncherDelegate::ShouldRunTest(
const testing::TestCase* test_case,
const testing::TestInfo* test_info) {
@@ -217,6 +201,10 @@ std::string GetPreTestName(const std::string& full_name) {
size_t WrapperTestLauncherDelegate::RunTests(
base::TestLauncher* test_launcher,
const std::vector<std::string>& test_names) {
+ dependent_test_map_.clear();
+ reverse_dependent_test_map_.clear();
+ user_data_dir_map_.clear();
+
// Number of additional tests to run because of dependencies.
size_t additional_tests_to_run_count = 0;
« no previous file with comments | « base/test/launcher/unit_test_launcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698