Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 13365005: Add GM mixed_xfermodes. This is a work in progress and will be used to test fixes for GPU Xfermodes… (Closed)

Created:
7 years, 8 months ago by bsalomon
Modified:
7 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add GM mixed_xfermodes. This is a work in progress and will be used to test fixes for GPU Xfermodes effects. Committed: https://code.google.com/p/skia/source/detail?r=8461

Patch Set 1 #

Total comments: 8

Patch Set 2 : comments and disable pipe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A gm/mixedxfermodes.cpp View 1 1 chunk +111 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
I may change this to not be random but the first thing I am using ...
7 years, 8 months ago (2013-03-30 14:52:13 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/13365005/diff/1/gm/mixedxfermodes.cpp File gm/mixedxfermodes.cpp (right): https://codereview.chromium.org/13365005/diff/1/gm/mixedxfermodes.cpp#newcode2 gm/mixedxfermodes.cpp:2: /* header date https://codereview.chromium.org/13365005/diff/1/gm/mixedxfermodes.cpp#newcode21 gm/mixedxfermodes.cpp:21: MixedXfermodesGM() ...
7 years, 8 months ago (2013-03-31 16:35:53 UTC) #2
bsalomon
Add GM mixed_xfermodes. This is a work in progress and will be used to test ...
7 years, 8 months ago (2013-04-01 18:02:42 UTC) #3
bsalomon
https://codereview.chromium.org/13365005/diff/1/gm/mixedxfermodes.cpp File gm/mixedxfermodes.cpp (right): https://codereview.chromium.org/13365005/diff/1/gm/mixedxfermodes.cpp#newcode2 gm/mixedxfermodes.cpp:2: /* On 2013/03/31 16:35:54, robertphillips wrote: > header date ...
7 years, 8 months ago (2013-04-01 18:02:58 UTC) #4
bsalomon
7 years, 8 months ago (2013-04-01 18:02:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r8461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698