Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1336463002: Webview Layout Test failure on Android (Closed)

Created:
5 years, 3 months ago by ramya.v
Modified:
5 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Webview Layout Test failure on Android Unexpected new webview interfaces found. CSSNamespaceRule support was added in https://codereview.chromium.org/1321943002. This patch updates the interface declaration for the same in android webview expected file. BUG=529790, 389549, 506603 Committed: https://crrev.com/abd3fc3a8be1c817dd44130e8a6e7b5098abfcbd Cr-Commit-Position: refs/heads/master@{#348381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M android_webview/tools/WebViewShell/test/webexposed/global-interface-listing-expected.txt View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ramya.v
Hi Tim, From the log shared in the bug, this could possibly the fix. Didn't ...
5 years, 3 months ago (2015-09-10 03:50:58 UTC) #2
Timothy Loh
Looks like (from git log on the file you're touching) timvolodine usually handles these
5 years, 3 months ago (2015-09-11 01:52:07 UTC) #4
timvolodine
On 2015/09/10 03:50:58, ramya.v wrote: > Hi Tim, > > From the log shared in ...
5 years, 3 months ago (2015-09-11 11:55:29 UTC) #5
ramya.v
On 2015/09/11 11:55:29, timvolodine wrote: > On 2015/09/10 03:50:58, ramya.v wrote: > > Hi Tim, ...
5 years, 3 months ago (2015-09-11 12:02:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336463002/1
5 years, 3 months ago (2015-09-11 12:02:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 12:11:56 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abd3fc3a8be1c817dd44130e8a6e7b5098abfcbd Cr-Commit-Position: refs/heads/master@{#348381}
5 years, 3 months ago (2015-09-11 12:12:58 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:21:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abd3fc3a8be1c817dd44130e8a6e7b5098abfcbd
Cr-Commit-Position: refs/heads/master@{#348381}

Powered by Google App Engine
This is Rietveld 408576698