Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: service/datastore/properties_test.go

Issue 1336443003: Implement projection queries correctly. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: fix comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/properties.go ('k') | service/datastore/reflect.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/properties_test.go
diff --git a/service/datastore/properties_test.go b/service/datastore/properties_test.go
index c535229306a6d9c2f65a8e61544b047b15c8cdaa..b09776d25cd5838b6ae4e8b5a4c3c2da5c88f700 100644
--- a/service/datastore/properties_test.go
+++ b/service/datastore/properties_test.go
@@ -53,7 +53,7 @@ func TestProperties(t *testing.T) {
pv := MkProperty(mybool(true))
So(pv.Value(), ShouldBeTrue)
So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
- So(pv.Type().String(), ShouldEqual, "PTBoolTrue")
+ So(pv.Type().String(), ShouldEqual, "PTBool")
})
Convey("string", func() {
pv := MkProperty(mystring("sup"))
@@ -116,17 +116,10 @@ func TestProperties(t *testing.T) {
So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
So(pv.Type().String(), ShouldEqual, "PTTime")
})
- Convey("[]byte coerces IndexSetting", func() {
+ Convey("[]byte allows IndexSetting", func() {
pv := Property{}
pv.SetValue([]byte("hello"), ShouldIndex)
So(pv.Value(), ShouldResemble, []byte("hello"))
- So(pv.IndexSetting(), ShouldEqual, NoIndex)
- So(pv.Type().String(), ShouldEqual, "PTBytes")
- })
- Convey("ByteString allows !IndexSetting", func() {
- pv := Property{}
- pv.SetValue(ByteString("hello"), ShouldIndex)
- So(pv.Value(), ShouldResemble, ByteString("hello"))
So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
So(pv.Type().String(), ShouldEqual, "PTBytes")
})
« no previous file with comments | « service/datastore/properties.go ('k') | service/datastore/reflect.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698