Implement projection queries correctly.

service/datastore/properties_test.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package datastore
 
 import (
         "math"
         "testing"
         "time"
@@ skipping 35 matching lines @@
                                         pv := MkProperty(19)
                                         So(pv.Value(), ShouldHaveSameTypeAs, int64(19))
                                         So(pv.Value(), ShouldEqual, 19)
                                         So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
                                         So(pv.Type().String(), ShouldEqual, "PTInt")
                                 })
                                 Convey("bool (true)", func() {
                                         pv := MkProperty(mybool(true))
                                         So(pv.Value(), ShouldBeTrue)
                                         So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
-                                        So(pv.Type().String(), ShouldEqual, "PTBoolTrue")
+                                        So(pv.Type().String(), ShouldEqual, "PTBool")
                                 })
                                 Convey("string", func() {
                                         pv := MkProperty(mystring("sup"))
                                         So(pv.Value(), ShouldEqual, "sup")
                                         So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
                                         So(pv.Type().String(), ShouldEqual, "PTString")
                                 })
                                 Convey("blobstore.Key is distinquished", func() {
                                         pv := MkProperty(blobstore.Key("sup"))
                                         So(pv.Value(), ShouldEqual, blobstore.Key("sup"))
@@ skipping 42 matching lines @@
                         })
                         Convey("time gets rounded", func() {
                                 pv := Property{}
                                 now := time.Now().In(time.UTC)
                                 now = now.Round(time.Microsecond).Add(time.Nanosecond * 313)
                                 pv.SetValue(now, ShouldIndex)
                                 So(pv.Value(), ShouldHappenBefore, now)
                                 So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
                                 So(pv.Type().String(), ShouldEqual, "PTTime")
                         })
-                        Convey("[]byte coerces IndexSetting", func() {
+                        Convey("[]byte allows IndexSetting", func() {
                                 pv := Property{}
                                 pv.SetValue([]byte("hello"), ShouldIndex)
                                 So(pv.Value(), ShouldResemble, []byte("hello"))
-                                So(pv.IndexSetting(), ShouldEqual, NoIndex)
-                                So(pv.Type().String(), ShouldEqual, "PTBytes")
-                        })
-                        Convey("ByteString allows !IndexSetting", func() {
-                                pv := Property{}
-                                pv.SetValue(ByteString("hello"), ShouldIndex)
-                                So(pv.Value(), ShouldResemble, ByteString("hello"))
                                 So(pv.IndexSetting(), ShouldEqual, ShouldIndex)
                                 So(pv.Type().String(), ShouldEqual, "PTBytes")
                         })
                 })
         })
 }
 
 func TestDSPropertyMapImpl(t *testing.T) {
         t.Parallel()
 
@@ skipping 38 matching lines @@
 
                                 Convey("weird value", func() {
                                         pm := PropertyMap{}
                                         err := pm.SetMeta("sup", complex(100, 20))
                                         So(err.Error(), ShouldContainSubstring, "bad type")
                                 })
                         })
                 })
         })
 }