Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1336443002: X87: [runtime] Replace many buggy uses of %_CallFunction with %_Call. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Replace many buggy uses of %_CallFunction with %_Call. port db2ba190dba6983b94eae36e111b0feebb97587e (r30634). original commit message: The semantics of the %_CallFunction intrinsic seem to be very unclear, which resulted in a lot of bugs. Especially the combination with %IsSloppyModeFunction is always a bug, because the receiver would be wrapped in the wrong context. So the %IsSloppyModeFunction helper is gone now, and many of the buggy uses of %_CallFunction are also eliminated. If you ever need to call something with a different receiver, then %_Call is your friend now. It does what you want and implements the call sequence fully (and correct). Committed: https://crrev.com/0cfa52d055586fe632564812e0a05b2a65612b90 Cr-Commit-Position: refs/heads/master@{#30667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +21 lines, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-10 03:40:36 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-10 05:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336443002/1
5 years, 3 months ago (2015-09-10 05:14:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 05:40:31 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 05:40:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cfa52d055586fe632564812e0a05b2a65612b90
Cr-Commit-Position: refs/heads/master@{#30667}

Powered by Google App Engine
This is Rietveld 408576698