Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1336433002: Revert of Expose distiller functions to JavaScript (Closed)

Created:
5 years, 3 months ago by Dan Beam
Modified:
5 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor-content
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expose distiller functions to JavaScript (patchset #14 id:260001 of https://codereview.chromium.org/1231083007/ ) Reason for revert: Broke GN compile http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/9325 http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/12931 [569/575] LINK(DLL) chrome.dll chrome.dll.lib FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp content_renderer.lib(distiller_native_javascript.obj) : error LNK2005: "public: static class v8::Object * __cdecl v8::Object::Cast(class v8::Value *)" (?Cast@Object@v8@@SAPAV12@PAVValue@2@@Z) already defined in v8.dll.lib(v8.dll) Original issue's description: > Expose distiller functions to JavaScript > > This change adds two mojo services; one for notifying a RenderFrame > that it is working on a distiller page and one for allowing distiller > JavaScript functions to access the browser. This CL only exposes a > single function "distiller.echo". > > BUG= > > Committed: https://crrev.com/c5fc07ec3016dc3fb0d58c6869f1fc9bedb8b3a7 > Cr-Commit-Position: refs/heads/master@{#347951} TBR=jochen@chromium.org,cjhopman@chromium.org,nasko@chromium.org,nyquist@chromium.org,stgao@chromium.org,mdjones@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5b77e8f46f38eb1592b17ec2e2fe97a148d96a65 Cr-Commit-Position: refs/heads/master@{#348075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -672 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc View 3 chunks +1 line, -66 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M components/dom_distiller.gypi View 4 chunks +2 lines, -44 lines 0 comments Download
M components/dom_distiller/content/BUILD.gn View 3 chunks +2 lines, -40 lines 0 comments Download
D components/dom_distiller/content/browser/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/dom_distiller/content/browser/distiller_javascript_service_impl.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/dom_distiller/content/browser/distiller_javascript_service_impl.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc View 5 chunks +4 lines, -20 lines 0 comments Download
D components/dom_distiller/content/common/distiller_javascript_service.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D components/dom_distiller/content/common/distiller_page_notifier_service.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
D components/dom_distiller/content/renderer/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h View 1 chunk +0 lines, -60 lines 0 comments Download
D components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D components/dom_distiller/content/renderer/distiller_native_javascript.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/dom_distiller/content/renderer/distiller_native_javascript.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +0 lines, -53 lines 0 comments Download
M content/renderer/dom_automation_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/dom_automation_controller.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
Created Revert of Expose distiller functions to JavaScript
5 years, 3 months ago (2015-09-10 02:22:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336433002/1
5 years, 3 months ago (2015-09-10 02:22:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 02:23:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b77e8f46f38eb1592b17ec2e2fe97a148d96a65 Cr-Commit-Position: refs/heads/master@{#348075}
5 years, 3 months ago (2015-09-10 02:24:00 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:28 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b77e8f46f38eb1592b17ec2e2fe97a148d96a65
Cr-Commit-Position: refs/heads/master@{#348075}

Powered by Google App Engine
This is Rietveld 408576698