DescriptionRevert of Expose distiller functions to JavaScript (patchset #14 id:260001 of https://codereview.chromium.org/1231083007/ )
Reason for revert:
Broke GN compile
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/9325
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/12931
[569/575] LINK(DLL) chrome.dll chrome.dll.lib
FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp
content_renderer.lib(distiller_native_javascript.obj) : error LNK2005: "public: static class v8::Object * __cdecl v8::Object::Cast(class v8::Value *)" (?Cast@Object@v8@@SAPAV12@PAVValue@2@@Z) already defined in v8.dll.lib(v8.dll)
Original issue's description:
> Expose distiller functions to JavaScript
>
> This change adds two mojo services; one for notifying a RenderFrame
> that it is working on a distiller page and one for allowing distiller
> JavaScript functions to access the browser. This CL only exposes a
> single function "distiller.echo".
>
> BUG=
>
> Committed: https://crrev.com/c5fc07ec3016dc3fb0d58c6869f1fc9bedb8b3a7
> Cr-Commit-Position: refs/heads/master@{#347951}
TBR=jochen@chromium.org,cjhopman@chromium.org,nasko@chromium.org,nyquist@chromium.org,stgao@chromium.org,mdjones@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/5b77e8f46f38eb1592b17ec2e2fe97a148d96a65
Cr-Commit-Position: refs/heads/master@{#348075}
Patch Set 1 #Messages
Total messages: 5 (0 generated)
|