Issue 133643006: Revert "Revert "Implement Element.matches(selectors)""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133643006: Revert "Revert "Implement Element.matches(selectors)"" (Closed)

Created:
6 years, 11 months ago by philipj_slow

Modified:
6 years, 11 months ago

Reviewers:
arv (Not doing code reviews), jochen (gone - plz use gerrit)

CC:
blink-reviews, caseq+blink_chromium.org, alph+blink_chromium.org, arv+blink, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Revert "Implement Element.matches(selectors)"" This re-lands <https://codereview.chromium.org/106983004>;, which was reverted in <https://codereview.chromium.org/103303005>;. The root bug causing the revert was fixed in Polymer in <https://github.com/Polymer/ShadowDOM/pull/332>; and reached Chromium in <https://codereview.chromium.org/98583008>;. BUG=326652 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164970

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -10 lines)			Patch
A	LayoutTests/fast/dom/Element/matches.html	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/Element/matches-expected.txt	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	Source/core/dom/Element.idl	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/133643006/1

6 years, 11 months ago (2014-01-13 15:08:35 UTC) #3

Message was sent while issue was closed.

Change committed as 164970

Expand Messages | Collapse Messages