Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: util/mac/launchd.mm

Issue 1336413003: In the .mm files use the crashpad::implicit_cast .. explicitly. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: implicitcast3: format Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/launchd.mm
diff --git a/util/mac/launchd.mm b/util/mac/launchd.mm
index 7aac68538ed56a57bc7591e01bb691c269855f0f..5f60526262ec9750bb1bfaf942638f83f16f5088 100644
--- a/util/mac/launchd.mm
+++ b/util/mac/launchd.mm
@@ -16,7 +16,6 @@
#import <Foundation/Foundation.h>
-#include "base/basictypes.h"
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_launch_data.h"
#include "base/mac/scoped_cftyperef.h"
@@ -45,8 +44,8 @@ launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) {
return nullptr;
}
- CFPropertyListRef value_cf =
- implicit_cast<CFPropertyListRef>([dictionary_ns objectForKey:key]);
+ CFPropertyListRef value_cf = crashpad::implicit_cast<CFPropertyListRef>(
+ [dictionary_ns objectForKey:key]);
launch_data_t value_launch = CFPropertyToLaunchData(value_cf);
if (!value_launch) {
return nullptr;
@@ -66,7 +65,7 @@ launch_data_t CFPropertyToLaunchData(CFPropertyListRef property_cf) {
for (id element_ns in array_ns) {
CFPropertyListRef element_cf =
- implicit_cast<CFPropertyListRef>(element_ns);
+ crashpad::implicit_cast<CFPropertyListRef>(element_ns);
launch_data_t element_launch = CFPropertyToLaunchData(element_cf);
if (!element_launch) {
return nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698